Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fetching contact's picture raises Encoding::UndefinedConversionError #422

Closed
mc-bro opened this issue Jul 20, 2023 · 1 comment · Fixed by #441
Closed

Fetching contact's picture raises Encoding::UndefinedConversionError #422

mc-bro opened this issue Jul 20, 2023 · 1 comment · Fixed by #441
Labels
bug

Comments

@mc-bro
Copy link

mc-bro commented Jul 20, 2023

Describe the bug
Fetching contact's picture raises Encoding::UndefinedConversionError ("\xFF" from ASCII-8BIT to UTF-8)

Similar issue was fixed some time ago here: #193

The solution is to pass encoding argument when creating a Tempfile:

Tempfile.new(encoding: 'ascii-8bit')
@mc-bro mc-bro added the bug label Jul 20, 2023
@mrashed-dev
Copy link
Contributor

Thanks for opening the issue @mc-bro, we will fix this and include it in a future release!

@mrashed-dev mrashed-dev mentioned this issue Nov 29, 2023
Merged
mrashed-dev added a commit that referenced this issue Dec 21, 2023
@mrashed-dev
Merge branch 'main' into TW-2384-gh-422-ruby-fetching-contacts-pictur…
d2426c8 
…e-raises
mrashed-dev added a commit that referenced this issue Dec 21, 2023
@mrashed-dev
Fix contact picture encoding error (#441)
125adcc 
This PR ensured that when we are dealing with contact picture, that we are using the correct encoding. Closes #422.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix contact picture encoding error nylas/nylas-ruby
2 participants
@mc-bro @mrashed-dev