Issue-394: Add disable_provider_selection kwarg to Api.authentication_url #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_url We need the option to disable the "Select different provider" button in Nylas' hosted auth when we are trying to authenticate against a specific provider. This is necessary to prevent our users from escaping the intended auth flow and selecting a provider that we do not support. This commit addresses this need by adding and optional keyword argument to the Api.authentication_url method and, if it is provided, including it in the params payload appended on the call to the /oauth/authorize endpoint. Tests have been added to account for this change and I tested it locally to confirm that the "Select different provider" button was no longer visible when I included disable_provider_selection: true in my call to the authentication_url method.
|
Hey @mrashed-dev @andreccosta! I'm not able to tag reviewers for this PR, but I saw you'd contributed recently and was curious if you'd mind taking a look at this for me. I'd be happy to share more about these changes and our need for them if needed. Thanks so much! |
kellyredding
approved these changes
Dec 15, 2022
There was a problem hiding this comment.
@PickertJoe Can I approve this? We'll see! 🚀
I think this change looks great! Nice that it was so easy to make.
mrashed-dev
approved these changes
Dec 16, 2022
There was a problem hiding this comment.
Thanks for your contribution @PickertJoe, looks good to me!
Codecov Report
@@ Coverage Diff @@
## main #395 +/- ##
=======================================
Coverage 97.73% 97.73%
=======================================
Files 126 126
Lines 4555 4555
=======================================
Hits 4452 4452
Misses 103 103
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
MethodTooLong
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #394
Description
We need the option to disable the "Select different provider" button in Nylas' hosted auth when we are trying to authenticate against a specific provider. This is necessary to prevent our users from escaping the intended auth flow and selecting a provider that we do not support.
This commit addresses this need by adding an optional keyword argument to the Api.authentication_url method and, if it is provided, including it in the params payload appended on the call to the /oauth/authorize endpoint. Tests have been added to account for this change and I tested it locally to confirm that the "Select different provider" button was no longer visible when I included disable_provider_selection: true in my call to the authentication_url method.
License
I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.