Fix calendar availability failing when round_robin is nil
#375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The availability endpoint only accepts optional params as an omitted value, not as a "null" value.
mrashed-dev
requested review from
a team,
quzhi1 and
arjunkalburgi
and removed request for
a team
|
CI is failing |
|
Thanks @quzhi1, CI is fixed now :) |
quzhi1
approved these changes
Jul 26, 2022
mrashed-dev
deleted the
TSDK-363-nylas-calendar-collection-availability-returns-nylas-invalid-request-when-round-robin-parameter-is-nil-github-issue-373
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR address the issue where, if
round_robinis left asnil, it always yields an error. This is because the Nylas Docs were out of date for the availability endpoint.round_robinis optional, and when omitted, returns collective availability. However, sendingnullis not valid despite what it says in the documentation. Now, we omit the value from the json payload if the value isnil.License
I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.