Incompatible with Go 1.23, which doesn't allow //go:linkname to internal symbols, including to net package

[stefanb]

While testing Go 1.23 rc1 in

• go 1.23, [email protected] 1.22.6 (new formula) Homebrew/homebrew-core#175310

there was an error:

  go: downloading github.com/tsosunchia/powclient v0.1.5
  # github.com/nxtrace/NTrace-core
  link: github.com/nxtrace/NTrace-core/trace/internal: invalid reference to net.internetSocket

Go 1.23 no longer allows //go:linkname * net.* link instructioins, see

• https://tip.golang.org/doc/go1.23#linker
• cmd/link: lock down future uses of linkname golang/go#67401

It is used several times in this module, see:

NTrace-core/trace/internal/icmp_darwin.go

Lines 14 to 18 in c1cd802

	//go:linkname internetSocket net.internetSocket
	func internetSocket(ctx context.Context, net string, laddr, raddr any, sotype, proto int, mode string, ctrlCtxFn func(context.Context, string, string, syscall.RawConn) error) (fd unsafe.Pointer, err error)
	//go:linkname newIPConn net.newIPConn
	func newIPConn(fd unsafe.Pointer) *net.IPConn

[fakeboboliu]

internetSocket is required to make a root-less ping on macOS, consider add -checklinkname=0 to build flags.

[tsosunchia]

69588b0
This project has updated the Golang version to v1.23

[stefanb]

Legit, but interesting to see that -ldflags=-checklinkname=0 workaround was chosen.

[tsosunchia]

Legit, but interesting to see that -ldflags=-checklinkname=0 workaround was chosen.

After weighing the options, this seems like the best choice.

[stefanb]

FYI, go 1.24 is around the corner (1.24rc2 already released) so you might want to give it a quick test.