Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Embeded video #9

Open
Moon-DaeSeung opened this issue Dec 25, 2022 · 1 comment
Open

Support Embeded video #9

Moon-DaeSeung opened this issue Dec 25, 2022 · 1 comment

Comments

@Moon-DaeSeung
Copy link

currently, notion2svelte does not support embeded video.
notion2svelte is amazing... and if you support 'type: video' it's gonna be super amazing.
here is what I want you to support
{
"object": "block",
"id": "a0519aab-0b29-447d-bd34-208da18e658b",
"parent": {
"type": "page_id",
"page_id": "1124ebcc-0e55-431f-bd22-a11702c0fdb4"
},
"created_time": "2022-12-25T13:22:00.000Z",
"last_edited_time": "2022-12-25T13:49:00.000Z",
"created_by": {
"object": "user",
"id": "95fc0174-8fc6-4114-8e45-f67eacd99f07"
},
"last_edited_by": {
"object": "user",
"id": "95fc0174-8fc6-4114-8e45-f67eacd99f07"
},
"has_children": false,
"archived": false,
"type": "paragraph",
"paragraph": {
"color": "default",
"text": []
}
}

@nvlgzr
Copy link
Owner

nvlgzr commented Jan 3, 2023

First, let me thank you for your words of praise, @Moon-DaeSeung! You're very kind. 🤓

As for implementing video embeds, I wonder if you'd be willing to help me out there. I don't have near-term plans to include videos in my own notion2svelte-based projects, so it's difficult to make it a high priority. The news isn't all bad, though, because you can fix it yourself and then make a pull request, benefiting any other users who might come along!

It can be daunting to work with a completely unfamiliar code base, so I'd be happy to get on a live chat + screenshare with you. I can get you set up with debugging, walk you through the basic structure of the code (it's pretty simple, actually!), and answer any questions you might have. If interested, let me know how to contact you directly and we can decide on a datetime & platform to meet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants