Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recursively fetching entire sub-pages can be…problematic #7

Open
nvlgzr opened this issue May 1, 2022 · 0 comments
Open

Recursively fetching entire sub-pages can be…problematic #7

nvlgzr opened this issue May 1, 2022 · 0 comments

Comments

@nvlgzr
Copy link
Owner

nvlgzr commented May 1, 2022

This has only affected me once: when trying out notion2svelte on a page that I didn't intend to publish.

The full story—for my own future benefit—stats with me wanting to "move" a custom-uploaded cover image from one page to another in my private Notion. The image in question turns out to have no URL, but rather a data:image: data:image/gif;base64,R0lGODlhAQABAIAAAAAAAP///yH5BAEAAAAALAAAAAABAAEAAAIBRAA7. This isn't the entire image, being far too terse, and I don't feel like researching exactly how Notion resolves it into the actual image. Instead, I was curious whether notion2svelte would download a usable image file that I could then re-upload to the new page.

(Side note: it turns out that the data:image comes through the Notion API as a .heic file. Notion doesn't allow these to be uploaded via the desktop app, so I've no idea how I managed to set it in the first place! Anyway…back to the potential problem with recursive fetching…)

The page I was testing happened to have some sub-pages with heavy image counts…mostly imported using the web clipper from other sites (e.g., Tufte). This isn't something I'm likely to do on accident when it comes to actual production use of notion2svelte, but it's worth noting for v2 that this should probably be handled elsewise. ¯\_(ツ)_/¯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant