Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redundant file open error messages with fmpopen.c #46

Open
wehimwich opened this issue May 12, 2020 · 0 comments
Open

redundant file open error messages with fmpopen.c #46

wehimwich opened this issue May 12, 2020 · 0 comments
Labels
cosmetic Doesn't impact functionality

Comments

@wehimwich
Copy link
Member

wehimwich commented May 12, 2020

From #45:

07:29:44?ERROR fm -1 Opening file: /usr2/proc/nothing.prc
07:29:44?ERROR bo -133 Error opening procedure library, UNIX 2: No such
file or directory

Added in a2f6bbc, while removing a non-logged error message when used with the FS, i.e., in a program that is "online". This was being conservative to avoid a silent error in case the caller did not handle the error. In fact, everywhere it is used in a FS online (i.e. not stand-alone), the error is logged normally, except aquir, where it could be fixed up easily (there are lots of other non-logged fmpsee/ errors though). In the case of aquir, this was a by-product of how it was incompletely promoted from an external to an internal FS program in 1ae556d. I can remember both of those errors, but finding them in the history with blame was relatively easy; especially since the second was apparently more about 25 years ago.

@wehimwich wehimwich added the cosmetic Doesn't impact functionality label May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cosmetic Doesn't impact functionality
Projects
None yet
Development

No branches or pull requests

1 participant