From d2852e69be1e3867f83a5fa77543a8fc2111c800 Mon Sep 17 00:00:00 2001 From: Sascha Cowley <16543535+SaschaCowley@users.noreply.github.com> Date: Fri, 30 Aug 2024 12:21:44 +1000 Subject: [PATCH 1/2] Revert change introduced in c333bef --- source/NVDAObjects/JAB/__init__.py | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/source/NVDAObjects/JAB/__init__.py b/source/NVDAObjects/JAB/__init__.py index f9d0ae3317c..faa7f8f4274 100644 --- a/source/NVDAObjects/JAB/__init__.py +++ b/source/NVDAObjects/JAB/__init__.py @@ -184,11 +184,8 @@ def _getLineOffsets(self, offset: int) -> tuple[int, int]: if end == -1 and offset > 0: # #1892: JAB returns -1 for the end insertion position # instead of returning the offsets for the last line. - # Try one character back, unless we're on a new line. - if self.obj.jabContext.getAccessibleTextRange(offset - 1, offset - 1) != "\n": - (start, end) = self.obj.jabContext.getAccessibleTextLineBounds(offset - 1) - else: - (start, end) = (offset, offset) + # Try one character back. + (start, end) = self.obj.jabContext.getAccessibleTextLineBounds(offset - 1) # Java gives end as the last character, not one past the last character end = end + 1 return (start, end) From d312a7b787d2d4a4cee6099729ee1d477a17cee7 Mon Sep 17 00:00:00 2001 From: Sascha Cowley <16543535+SaschaCowley@users.noreply.github.com> Date: Fri, 30 Aug 2024 12:27:33 +1000 Subject: [PATCH 2/2] Added change log entry --- user_docs/en/changes.md | 1 + 1 file changed, 1 insertion(+) diff --git a/user_docs/en/changes.md b/user_docs/en/changes.md index c424cbc5f85..0600ff9e52d 100644 --- a/user_docs/en/changes.md +++ b/user_docs/en/changes.md @@ -61,6 +61,7 @@ There have also been a number of fixes, including to mouse tracking in Firefox, * It is now possible to interact with Data validation dropdown lists in Microsoft Excel 365. (#15138) * NVDA is no longer as sluggish when arrowing up and down through large files in VS Code. (#17039) * NVDA no longer becomes unresponsive after holding down an arrow key for a long time while in browse mode, particularly in Microsoft Word and Microsoft Outlook. (#16812) +* NVDA no longer reads the last line when the cursor is on the second-last line of a multiline edit control in Java applications. (#17027) ### Changes for Developers