Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint/format C++ code #17009

Closed
LeonarddeR opened this issue Aug 15, 2024 · 1 comment
Closed

Lint/format C++ code #17009

LeonarddeR opened this issue Aug 15, 2024 · 1 comment
Milestone

Comments

@LeonarddeR
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

Multiple code styles are mixed in NVDA's C++ code

Describe the solution you'd like

Apply auto linting/formatting to the code base, similar to what we do with Ruff.

Describe alternatives you've considered

Leave as is.

Additional context

I have experimented with clangformat in jcsteh/osara#940 . The idea there is to find a format that minimized changes to OSARA's code base. However, there were several side effects to clangformat that resulted in pretty ugly results with spacing. I'm therefore not sure clangformat is the way to go.

CC @seanbudd

@seanbudd
Copy link
Member

Closing in favour of #12407

@seanbudd seanbudd closed this as not planned Won't fix, can't repro, duplicate, stale Aug 15, 2024
@github-actions github-actions bot added this to the 2024.4 milestone Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants