Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support HID standard multi-line braille displays #16993

Closed
alexmoon opened this issue Aug 12, 2024 · 1 comment · Fixed by #17001
Closed

Support HID standard multi-line braille displays #16993

alexmoon opened this issue Aug 12, 2024 · 1 comment · Fixed by #17001
Labels
p5 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation.
Milestone
2024.4

Comments

@alexmoon
Copy link
Contributor

Is your feature request related to a problem? Please describe.

The hidBrailleStandard driver currently does not support multi-line braille displays, such as Tactile Engineering's Cadence. It only finds the first braille row capability and ignores any subsequent rows. As a result, only the first line of braille cells is used on the display.

Describe the solution you'd like

The hidBrailleStandard driver should detect all braille row capabilities and set numRows/numCols appropriately. This would allow NVDA to address all available braille cells and allow HID standard multi-line braille displays to support any future multi-line braille capabilities NVDA might add. I'm happy to create a PR to add this functionality.

Describe alternatives you've considered

None.

Additional context

USB standard HID Usage Tables
@michaelDCurran michaelDCurran added triaged Has been triaged, issue is waiting for implementation. p5 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority labels Aug 12, 2024
@michaelDCurran
Copy link
Member

@alexmoon If you have a physical display to test with, please open a pr by all means. I agree with your approach. I am currently in discussion with some other display manufacturers where I am proposing the same thing, so I am glad to see alignment. Unfortunately so far I do not have a display that exposes this enhancement to test with.

@alexmoon alexmoon mentioned this issue Aug 13, 2024
Merged
5 tasks
seanbudd pushed a commit that referenced this issue Aug 15, 2024
@alexmoon
Support multi-line braille displays in HidBrailleDriver (#17001)
83b2e0a 
Closes #16993

Summary of the issue:
Multi-line braille displays using the HID standard driver only support the first line of cells.

Description of user facing changes
Users with multi-line braille displays that connect using the HidBrailleDriver will now be able to use all cells of their display.

Description of development approach
HidBrailleDriver._cellValueCaps is now a list of all braille cell controls in the device. numRows is set to the length of that list and numCols is set to the ReportCount of each element of the list. In display, the cells are split across the elements of _cellValueCaps.
@github-actions github-actions bot added this to the 2024.4 milestone Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p5 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation.
Projects
None yet
Milestone
2024.4
Development

Successfully merging a pull request may close this issue.

Support multi-line braille displays in HidBrailleDriver tactile-eng/nvda
2 participants
@alexmoon @michaelDCurran