Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Expose zlib as a public link dependency for triton client debug builds #1495

Open
2 tasks done
cwharris opened this issue Feb 5, 2024 · 0 comments
Open
2 tasks done
Labels
bug Something isn't working

Comments

@cwharris
Copy link
Contributor

cwharris commented Feb 5, 2024

Version

24.03

Which installation method(s) does this occur on?

No response

Describe the bug.

As of #1468, Morpheus privately links ZLIB for debug builds because it's required when using triton client in debug builds. However, Morpheus does not use ZLIB directly. We should update the triton client patch in the utilities repo to expose ZLIB as a PUBLIC link dependency for debug builds rather than just a PRIVATE link dependency, and remove the explicit link dependency on ZLIB from Morpheus entirely.

Minimum reproducible example

No response

Relevant log output

Click here to see error details

[Paste the error here, it will be hidden by default]

Full env printout

Click here to see environment details

[Paste the results of print_env.sh here, it will be hidden by default]

Other/Misc.

No response

Code of Conduct

  • I agree to follow Morpheus' Code of Conduct
  • I have searched the open bugs and have found no duplicates for this bug report
@cwharris cwharris added the bug Something isn't working label Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Todo
Development

No branches or pull requests

1 participant