Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of nuts-node code #47

Open
woutslakhorst opened this issue Jun 7, 2021 · 2 comments
Open

Remove use of nuts-node code #47

woutslakhorst opened this issue Jun 7, 2021 · 2 comments

Comments

@woutslakhorst
Copy link
Member

rely on client code generation from OAS. The current setup already confuses devs.

@stevenvegt
Copy link
Member

Would like to know what the confusion was about. Generating the code locally instead of including it from the nuts-node repository might not fix the confusion.
Were they familiar with the oapi spec? Were they able to read the golang code? Did they follow the introduction manual? The names of the client lib follows roughly the operationIDs from the swagger spec, so i'm curious why that did was not enough.

Perhaps we should enable the swagger client on the nuts-node in development mode, so people can play with the api themselves? Like https://github.com/swaggo/echo-swagger ?

@woutslakhorst
Copy link
Member Author

If the demo is also to be a blueprint and thus also give an estimate on the amount of work others will have to do, then it should also include the client code generation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants