Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle ValueError during socket device shutdown #65

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Handle ValueError during socket device shutdown #65

wants to merge 1 commit into from

Conversation

jjlawren
Copy link

When the socket is closed down unexpectedly a ValueError can be thrown while waiting for a message:

2022-02-05 13:49:03 ERROR (Thread-3) [root] Uncaught thread exception
Traceback (most recent call last):
  File "/usr/lib/python3.9/threading.py", line 973, in _bootstrap_inner
    self.run()
  File "/srv/homeassistant/venv/lib/python3.9/site-packages/alarmdecoder/devices/base_device.py", line 148, in run
    self._device.read_line(timeout=self.READ_TIMEOUT)
  File "/srv/homeassistant/venv/lib/python3.9/site-packages/alarmdecoder/devices/socket_device.py", line 323, in read_line
    read_ready, _, _ = select.select([self._device], [], [], 0.5)
ValueError: file descriptor cannot be a negative integer (-1)

Fixes #64

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@f34rdotcom f34rdotcom f34rdotcom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ValueError: file descriptor cannot be a negative integer (-1)
2 participants
@jjlawren @f34rdotcom