From e317854a0b1def8ae34dd726cc08b12c17398923 Mon Sep 17 00:00:00 2001 From: Takeshi Yoneda Date: Mon, 25 Nov 2024 11:58:35 -0800 Subject: [PATCH] Removes setting `BAZEL_BUILD_EXTRA_OPTIONS` in .devcontainer/setup.sh (#37354) This removes the unnecessary default bazelrc configuration used in .devcontainer. This was a cause of #23239 people asked about multiple times before. Closes #23239 Signed-off-by: Takeshi Yoneda --- .devcontainer/setup.sh | 6 ------ 1 file changed, 6 deletions(-) diff --git a/.devcontainer/setup.sh b/.devcontainer/setup.sh index 421db0f0b61a..512cef4ea5e8 100755 --- a/.devcontainer/setup.sh +++ b/.devcontainer/setup.sh @@ -2,12 +2,6 @@ BAZELRC_FILE=~/.bazelrc bazel/setup_clang.sh /opt/llvm -# TODO(phlax): use user.bazelrc -# Use generated toolchain config because we know the base container is the one we're using in RBE. -# Not using libc++ here because clangd will raise some tidy issue in libc++ header as of version 9. -echo "build --config=rbe-toolchain-clang-libc++" >> ~/.bazelrc -echo "build ${BAZEL_BUILD_EXTRA_OPTIONS}" | tee -a ~/.bazelrc - # Ideally we want this line so bazel doesn't pollute things outside of the devcontainer, but some of # API tooling (proto_sync) depends on symlink like bazel-bin. # TODO(lizan): Fix API tooling and enable this again