Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] separate out such third party dependencies (i.e. OpenSSL) #288

Open
ntnx-dlane opened this issue Feb 16, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@ntnx-dlane
Copy link

Describe the request
pre-build the wheel files to remove dependencies on third parties like OpenSSL

Current behaviour
When setting up Calm DSL, wheel files must be built.

For Windows builds (using current versions of openssl) as of 2/16/2024, when the wheel file is built for scrypt, errors are received:

Collecting scrypt
  Downloading scrypt-0.8.20.tar.gz (55 kB)
     ---------------------------------------- 55.9/55.9 kB 1.5 MB/s eta 0:00:00
  Installing build dependencies ... done
  Getting requirements to build wheel ... done
  Installing backend dependencies ... done
  Preparing metadata (pyproject.toml) ... done
Building wheels for collected packages: scrypt
  Building wheel for scrypt (pyproject.toml) ... error
  error: subprocess-exited-with-error

  × Building wheel for scrypt (pyproject.toml) did not run successfully.
  │ exit code: 1
....
LINK : fatal error LNK1181: cannot open input file 'libcrypto_static.lib'
      error: command 'C:\\Program Files (x86)\\Microsoft Visual Studio\\2022\\BuildTools\\VC\\Tools\\MSVC\\14.39.33519\\bin\\HostX86\\x64\\link.exe' failed with exit code 1181
      [end of output] 

Expected behaviour

pre-building the wheel files will remove the requirement for the client to build the wheel file.

@ntnx-dlane ntnx-dlane added the enhancement New feature or request label Feb 16, 2024
@gauravpandvia
Copy link

Jira Ticket - https://jira.nutanix.com/browse/CALM-43617

dwivediprab pushed a commit that referenced this issue Mar 15, 2024
)

Passing with_endpoints flag value to the publish_runbook functions.

1. --with_endpoints flag set and runbook published in marketplace
<img width="613" alt="Screenshot 2023-10-04 at 2 44 59 PM"
src="https://github.com/ideadevice/calm-dsl/assets/134352330/1024ece1-1bdd-4f7c-9ad0-aaee83f1bc07">

> (venv) [Wed Oct 04 11:25:28 nutanix@richa-kumari:~/calm-dsl ] calm
publish runbook --name "My Runbook 1" --version 1.2.6 --project "test
project" --with_secrets --with_endpoints --publish_to_marketplace
"test_rb"
[2023-10-04 11:25:50] [INFO] [calm.dsl.cli.marketplace:1636] Fetching
existing marketplace runbooks with name My Runbook 1
[2023-10-04 11:25:51] [INFO] [calm.dsl.cli.runbooks:596] test_rb found
[2023-10-04 11:25:52] [INFO] [calm.dsl.cli.marketplace:1615] Marketplace
Runbook is published to marketplace manager successfully
[2023-10-04 11:25:52] [INFO] [calm.dsl.cli.marketplace:1081] Fetching
details of pending marketplace item My Runbook 1 with version 1.2.6
[2023-10-04 11:25:54] [INFO] [calm.dsl.cli.marketplace:1154] Marketplace
Item My Runbook 1 with version 1.2.6 is approved successfully
[2023-10-04 11:25:54] [INFO] [calm.dsl.cli.marketplace:1185] Fetching
details of accepted marketplace item My Runbook 1 with version 1.2.6
[2023-10-04 11:25:55] [INFO] [calm.dsl.cli.marketplace:1265] Marketplace
Item is published to marketplace successfully

2. --with_endpoints flag not set
<img width="592" alt="Screenshot 2023-10-04 at 2 45 08 PM"
src="https://github.com/ideadevice/calm-dsl/assets/134352330/77de168f-099a-4e7c-866a-df389fcee0e6">

> (venv) [Wed Oct 04 11:27:22 nutanix@richa-kumari:~/calm-dsl ] calm
publish runbook --name "My Runbook 1" --version 1.2.7 --project "test
project" --with_secrets -e "test_r
b"
[2023-10-04 11:28:12] [INFO] [calm.dsl.cli.marketplace:1703] Fetching
existing marketplace runbooks with name My Runbook 1
[2023-10-04 11:28:13] [INFO] [calm.dsl.cli.marketplace:1727] Fetching
existing versions of Marketplace Item My Runbook 1
[2023-10-04 11:28:13] [INFO] [calm.dsl.cli.runbooks:596] test_rb found
[2023-10-04 11:28:13] [INFO] [calm.dsl.cli.marketplace:1615] Marketplace
Runbook is published to marketplace manager successfully

JIRA - https://jira.nutanix.com/browse/CALM-39483

(cherry picked from commit aeb3f630b8f1aa77412354659fd39771cca02444)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants