Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Right prompt redraw issue in nu 0.101 #864

Closed
blindFS opened this issue Dec 29, 2024 · 4 comments
Closed

Right prompt redraw issue in nu 0.101 #864

blindFS opened this issue Dec 29, 2024 · 4 comments
Labels
A-Display Area: Correctness of the display output and additional features needed there bug Something isn't working

Comments

@blindFS
Copy link
Contributor

blindFS commented Dec 29, 2024

Platform macOS
Terminal software ghostty

Describe the problem you are observing.

Noticed that right prompt redraw happens with resize in nu 0.101.0
But there's a side effect as shown in the screenshot

Steps to reproduce

  1. set some right prompt
  2. multiline left prompt
  3. resize horizontally

Screenshots/Screencaptures

Screen.Recording.2024-12-29.at.9.53.14.AM.mov

possibly related to #857

@blindFS blindFS added the bug Something isn't working label Dec 29, 2024
@blindFS
Copy link
Contributor Author

blindFS commented Dec 29, 2024

It turns out that single-line left prompt can trigger it as well.

@sholderbach
Copy link
Member

Guess that's a downside from the change in #857.

So the question if we can fix the prompt position/wrapping computation or better forgo the redraw.

@sholderbach sholderbach added the A-Display Area: Correctness of the display output and additional features needed there label Jan 8, 2025
@blindFS
Copy link
Contributor Author

blindFS commented Jan 8, 2025

Another call of redraw

#841 (comment)

worked well for me back then

@blindFS
Copy link
Contributor Author

blindFS commented Jan 25, 2025

Confirmed that it's not caused by recent reedline changes. Should be a nushell issue.

@blindFS blindFS closed this as completed Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Display Area: Correctness of the display output and additional features needed there bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants