Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slow performance when holding down enter #825

Open
ymcx opened this issue Sep 10, 2024 · 1 comment
Open

Slow performance when holding down enter #825

ymcx opened this issue Sep 10, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@ymcx
Copy link

ymcx commented Sep 10, 2024

Platform Only tested on Linux, other platforms could be affected as well.
Terminal software Most noticable on (or only affects?) VTE-based terminal emulators.

Press and hold down the enter key for a couple of seconds and once lifted you'll notice how Reedline keeps rendering new lines for a relatively long period of time. The regression got introduced in #675 and more precisely after adding the is_reset() check to each repaint in src/painting/painter.rs.

Steps to reproduce

  1. Open a VTE-based terminal emulator (like kgx)
  2. Press and hold down the enter key.
  3. Notice the delay until the screen stops updating after letting go of the key.

Screenshots/Screencaptures

On the left you can see how it looks like after getting rid of the is_reset() call. To better illustrate the bug, I shook the cursor once letting go of the enter key.
Even though the screencap is on an older version of Reedline, the bug is still reproducible on newer versions.

Screencast.from.2024-09-10.19-59-14.mp4
@ymcx ymcx added the bug Something isn't working label Sep 10, 2024
@fdncred
Copy link
Collaborator

fdncred commented Sep 10, 2024

Seen it before. Experienced it. Don't like the current behavior at all. Would like to see a PR to fix it without introducing more resize artifacts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants