Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different color struct #819

Open
tisonkun opened this issue Aug 22, 2024 · 1 comment
Open

Different color struct #819

tisonkun opened this issue Aug 22, 2024 · 1 comment

Comments

@tisonkun
Copy link
Contributor

reedline/src/prompt/base.rs

Lines 100 to 106 in 020142f

/// Get the default prompt color
fn get_prompt_color(&self) -> Color {
DEFAULT_PROMPT_COLOR
}
/// Get the default multiline prompt color
fn get_prompt_multiline_color(&self) -> nu_ansi_term::Color {
DEFAULT_PROMPT_MULTILINE_COLOR

Why do we use different color struct for similar prompt color settings?

Is it still possible to align them?

@sholderbach
Copy link
Member

That seems to be an oversight at some point. Not sure where the impact would be when changing to one or the other.

In general I am inclined to say we should simplify the prompt trait. In nushell most prompts do their own color ornamentation inside the prompt string so the whole notion of having prompt color(s) is a bit redundant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants