forked from se-edu/addressbook-level3
-
Notifications
You must be signed in to change notification settings - Fork 16
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: nus-oss/AB3-J17
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.3.0
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: nus-oss/AB3-J17
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 12 commits
- 38 files changed
- 9 contributors
Commits on Jul 11, 2024
-
Let's migrate to Java 17 so as not to fall too far behind the latest LTS version (currently, 21). Contributoring authors: @baskargopinath, @bennyLCK, @billyhoce, @gongg21, @hjungwoo01, @jedkohjk, @jyue487, @itstrueitstrueitsrealitsreal, @brein62, @aureliony, @ljy0422, @macareonie, @ryanozx, @Carlintyj, @teoks0199, @drustanyjt
damithc committedJul 11, 2024 Loading Loading status checks…Configuration menu - View commit details
-
Copy full SHA for fe805d8 - Browse repository at this point
Copy the full SHA fe805d8View commit details
Commits on Jul 20, 2024
-
Configuration menu - View commit details
-
Copy full SHA for a736a75 - Browse repository at this point
Copy the full SHA a736a75View commit details
Commits on Jul 23, 2024
-
MainApp.java: Fix typo Address Book -> AddressBook
When launching AB3 from terminal using java -jar, the start of logging says 'Starting AddressBook' while the end says 'Stopping Address Book'. Let's fix this inconsistency by changing it to 'Stopping AddressBook' in MainApp.java.
Configuration menu - View commit details
-
Copy full SHA for 934f740 - Browse repository at this point
Copy the full SHA 934f740View commit details
Commits on Jul 26, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 87a1319 - Browse repository at this point
Copy the full SHA 87a1319View commit details
Commits on Jul 30, 2024
-
Revert TLS workaround after upgrading to JDK17
The SSLProtocolException error when uploading test coverage information no longer occurs with JDK17, so the past workaround of disabling TLSv1.3 is no longer needed. Let's remove the workaround and re-enable TLSv1.3.
Configuration menu - View commit details
-
Copy full SHA for 82598c1 - Browse repository at this point
Copy the full SHA 82598c1View commit details -
UserGuide.md: Make JAR download step generic (#28)
Currently, every time a new release is done, developers would have to update the file name to reflect the latest JAR file published. This can be difficult to keep track of. Let's change the JAR download step (step 2) in the Quick Start section in the user guide to say "latest `.jar` file" instead of "latest `addressbook.jar`". This serves to make the JAR download step generic, eliminating the need for developers to update the file name every time a new release is published.
Configuration menu - View commit details
-
Copy full SHA for 3da04ac - Browse repository at this point
Copy the full SHA 3da04acView commit details -
UG: Add help window known issue
The Help Window cannot be activated if the previous Help Window is still alive but minimized. Until there is a better solution, let's mention this problem in the 'Known issues' section of the UG.
Configuration menu - View commit details
-
Copy full SHA for 5af1c6d - Browse repository at this point
Copy the full SHA 5af1c6dView commit details
Commits on Aug 4, 2024
-
As the tutorials have been moved to https://se-education.org/guides/tutorials/ab3.html, let's remove them from this codebase.
Configuration menu - View commit details
-
Copy full SHA for 885a5ab - Browse repository at this point
Copy the full SHA 885a5abView commit details
Commits on Aug 8, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 351d006 - Browse repository at this point
Copy the full SHA 351d006View commit details -
Update Gradle Wrapper Validation Action to v3
The current version (v1) of Gradle Wrapper Validation Action is outdated and may stop working in the future. Let's update the workflow dependency, and use the format as recommended in https://github.com/gradle/wrapper-validation-action/blob/main/README.md.
Configuration menu - View commit details
-
Copy full SHA for 6f00272 - Browse repository at this point
Copy the full SHA 6f00272View commit details -
Update setup-java action to v4
The current version (v1) of the setup-java action is outdated, and may stop working in the future. As newer versions of the action require the 'distribution' field, 'zulu' is specified, which is the default used in v1. Let's update the workflow dependency, and use the format as recommended in https://github.com/actions/setup-java/blob/main/README.md.
Configuration menu - View commit details
-
Copy full SHA for 4209f9c - Browse repository at this point
Copy the full SHA 4209f9cView commit details -
The current version (v3) of the codecov action had previously stopped working (nus-cs2103-AY2324S2/forum#729), and may stop working again in the future. Let's update the codecov action to the latest version (v4) to minimize the chance of it breaking, and use the format as recommended in https://github.com/codecov/codecov-action/blob/main/README.md.
Configuration menu - View commit details
-
Copy full SHA for 93e00db - Browse repository at this point
Copy the full SHA 93e00dbView commit details
There are no files selected for viewing