Validate device on constructor

Author: giahuy98

include/tap_protocol/tap_protocol.h

@@ -5,6 +5,7 @@
 #include <vector>
 #include <cstddef>
 #include <string>
+#include <cstdint>
 
 namespace tap_protocol {
 using Bytes = std::vector<unsigned char>;

src/satscard.cpp

@@ -125,6 +125,12 @@ Satscard::Satscard(std::unique_ptr<Transport> transport)
     : CKTapCard(std::move(transport), false) {
   auto st = FirstLook();
 
+  if (st.tapsigner) {
+    throw TapProtoException(
+        TapProtoException::INVALID_DEVICE,
+        "Incorrect device type detected. Please try again.");
+  }
+
   if (GetActiveSlotStatus() == SlotStatus::SEALED) {
     RenderActiveSlotAddress(st);
   }

src/tapsigner.cpp

@@ -58,7 +58,12 @@ void from_json(const nlohmann::json& j, Tapsigner::BackupResponse& t) {
 
 Tapsigner::Tapsigner(std::unique_ptr<Transport> transport)
     : CKTapCard(std::move(transport), false) {
-  FirstLook();
+  auto st = FirstLook();
+  if (!st.tapsigner) {
+    throw TapProtoException(
+        TapProtoException::INVALID_DEVICE,
+        "Incorrect device type detected. Please try again.");
+  }
   CertificateCheck();
 }
 

tests/connection_test.cpp

@@ -56,3 +56,19 @@ TEST_CASE("type of card") {
     CHECK(st.proto == 1);
   }
 }
+
+TEST_CASE("invalid card") {
+  std::unique_ptr<tap_protocol::Transport> tp =
+      std::make_unique<CardEmulator>();
+
+  tap_protocol::CKTapCard card(std::move(tp));
+  if (card.IsTapsigner()) {
+    CHECK_THROWS_AS(
+        { auto tapsigner = tap_protocol::ToSatscard(std::move(card)); },
+        tap_protocol::TapProtoException);
+  } else {
+    CHECK_THROWS_AS(
+        { auto satscard = tap_protocol::ToTapsigner(std::move(card)); },
+        tap_protocol::TapProtoException);
+  }
+}

tests/tapsigner_test.cpp

@@ -14,16 +14,6 @@
 // $ ./ecard.py emulate -t
 // $ ./ecard.py emulate -t --no-init # fresh card
 
-TEST_CASE("tapsigner to satscard") {
-  std::unique_ptr<tap_protocol::Transport> tp =
-      std::make_unique<CardEmulator>();
-  tap_protocol::Tapsigner tapsigner(std::move(tp));
-  if (!tapsigner.IsTapsigner()) {
-    auto satscard = tap_protocol::ToSatscard(std::move(tapsigner));
-    MESSAGE("satscard active slot: ", satscard->GetActiveSlotIndex());
-  }
-}
-
 TEST_SUITE_BEGIN("tapsigner" * doctest::skip([]() -> bool {
                    std::unique_ptr<tap_protocol::Transport> tp =
                        std::make_unique<CardEmulator>();