⚗️(frontend) show username on AccountDropDown #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daproclaima
force-pushed
the
feature/dropdown-account
branch
5 times, most recently
from
74bb43f
to
f056b29
Compare
AntoLC
reviewed
Sep 20, 2024
src/frontend/apps/desk/src/features/header/__tests__/AccountDropdown.test.tsx
Outdated
Show resolved
Hide resolved
src/frontend/apps/desk/src/features/header/__tests__/AccountDropdown.test.tsx
Outdated
Show resolved
Hide resolved
src/frontend/apps/desk/src/features/header/__tests__/AccountDropdown.test.tsx
Outdated
Show resolved
Hide resolved
daproclaima
force-pushed
the
feature/dropdown-account
branch
2 times, most recently
from
8b0756f
to
d0ffd8b
Compare
AntoLC
reviewed
Sep 24, 2024
daproclaima
force-pushed
the
feature/dropdown-account
branch
from
d0ffd8b
to
d70400c
Compare
Yes, I noticed it too. It looks like this behavior is integrated into the Cunningham Dropwown component. |
AntoLC
approved these changes
Sep 24, 2024
- show username instead of "My account" - udpate translations and tests
daproclaima
force-pushed
the
feature/dropdown-account
branch
from
d70400c
to
9bb6036
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Knowing who we are once logged in La Régie would be useful.
Proposal
Show the full name of the currently connected user on the account drop down in the right top corner
Before
Before.dropdown.change.mp4
After
After.dropdown.change.mp4