Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid extending implicit eval if possible #185

Open
Keno opened this issue Oct 17, 2024 · 0 comments
Open

Avoid extending implicit eval if possible #185

Keno opened this issue Oct 17, 2024 · 0 comments

Comments

@Keno
Copy link

Keno commented Oct 17, 2024

The eval and include names are implicitly created by the core system to allow evaluating into a particular module inside of it without having to repeat the module name. Extending these builtin generic functions is currently allowed, although this is a bit of an accidental byproduct of the way they are defined and this may change in JuliaLang/julia#55949. If possible, I would suggest renaming the eval methods in this package to avoid implicitly extending the implicit methods. Alternatively, it is possible to suppress creation of the implicit methods by using baremodule (see e.g. phelipe/Fuzzy.jl#21 for that approach). I would have submitted a pull request, but I lack understanding of the organization of this package to decide which approach is the correct one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant