Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to_dot and the optimization from DiagTree to Graph #169

Merged
merged 29 commits into from
Dec 28, 2023

Conversation

houpc
Copy link
Member

@houpc houpc commented Dec 22, 2023

No description provided.

@houpc houpc self-assigned this Dec 22, 2023
@codecov-commenter
Copy link

codecov-commenter commented Dec 22, 2023

Codecov Report

Attention: 278 lines in your changes are missing coverage. Please review.

Comparison is base (3317708) 62.36% compared to head (1624693) 57.95%.
Report is 4 commits behind head on computgraph.

Files Patch % Lines
src/computational_graph/transform.jl 0.00% 66 Missing ⚠️
src/parquet_builder/sigmaGV.jl 0.00% 59 Missing ⚠️
src/frontend/GV.jl 0.00% 57 Missing ⚠️
src/computational_graph/optimize.jl 43.85% 32 Missing ⚠️
src/computational_graph/tree_properties.jl 0.00% 22 Missing ⚠️
src/backend/to_dot.jl 0.00% 18 Missing ⚠️
src/utility.jl 0.00% 15 Missing ⚠️
src/frontend/diagtree.jl 0.00% 9 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@               Coverage Diff               @@
##           computgraph     #169      +/-   ##
===============================================
- Coverage        62.36%   57.95%   -4.41%     
===============================================
  Files               66       67       +1     
  Lines             4995     5294     +299     
===============================================
- Hits              3115     3068      -47     
- Misses            1880     2226     +346     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@houpc houpc merged commit ec586d9 into computgraph Dec 28, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants