Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FrontEnds API and Bugfix #156

Merged
merged 8 commits into from
Nov 17, 2023
Merged

Update FrontEnds API and Bugfix #156

merged 8 commits into from
Nov 17, 2023

Conversation

houpc
Copy link
Member

@houpc houpc commented Nov 14, 2023

No description provided.

@houpc houpc added bug Something isn't working documentation Improvements or additions to documentation refactor refactor the code labels Nov 14, 2023
@houpc houpc self-assigned this Nov 14, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 14, 2023

Codecov Report

Attention: 35 lines in your changes are missing coverage. Please review.

Comparison is base (0e1b073) 68.07% compared to head (8405f2c) 68.35%.

Files Patch % Lines
src/frontend/GV.jl 27.58% 21 Missing ⚠️
src/frontend/GV_diagrams/readfile.jl 74.07% 7 Missing ⚠️
src/frontend/LabelProduct.jl 80.55% 7 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@               Coverage Diff               @@
##           computgraph     #156      +/-   ##
===============================================
+ Coverage        68.07%   68.35%   +0.28%     
===============================================
  Files               64       64              
  Lines             4501     4516      +15     
===============================================
+ Hits              3064     3087      +23     
+ Misses            1437     1429       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

end
return loc
end

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

documentation

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will add docs in the next PR.

@@ -134,6 +137,38 @@ Print the LabelProduct.
"""
Base.show(io::IO, obj::LabelProduct) = print(io, "LabelProduct of: $(obj.labels)")

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

documentation

@houpc houpc merged commit 1e717bb into computgraph Nov 17, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation refactor refactor the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants