Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python setup.py clean --all does not remove ffi/build #567

Open
ARF1 opened this issue Mar 30, 2020 · 4 comments · May be fixed by #569
Open

python setup.py clean --all does not remove ffi/build #567

ARF1 opened this issue Mar 30, 2020 · 4 comments · May be fixed by #569
Labels
bug build

Comments

@ARF1
Copy link
Contributor

ARF1 commented Mar 30, 2020

If one calls python setup.py build the directory ffi/build is created. python setup.py clean --all does not remove it however.

This is a problem because stale builds can persist. For example pip install . fails because of this if python setup.py build was previously executed.
@esc esc added the bug label Mar 31, 2020
@esc
Copy link
Member

esc commented Mar 31, 2020

@ARF1 thanks for submitting this. Can you discern, if this caused by the code Numba developers wrote in the setup.py or is this a failure of the Python build system?

@ARF1
Copy link
Contributor Author

ARF1 commented Mar 31, 2020

@esc I have never really written a non-trivial setup.py but I think setup.py is to blame. - At least indirectly: From what I can tell at a glance ffi/build is created by ffi/build.py - which is somehow called by setup.py. But unless setup.py is told about the directory created by ffi/build.py it has no way to know about it. - That is just my guess though. I have not really looked into it.

@seibert
Copy link
Contributor

seibert commented Mar 31, 2020

@sklam wrote this originally, and it was doing some hacky things to try to handle building a standalone shared library that isn't a Python extension. Not sure if he recalls how this was supposed to work.

@ARF1 ARF1 linked a pull request Apr 1, 2020 that will close this issue
Open
@ARF1
Copy link
Contributor Author

ARF1 commented Apr 1, 2020

Fix in #569

@esc esc added the build label Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug build
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

clean ffi/build with setup.py clean ARF1/llvmlite
3 participants
@esc @seibert @ARF1