Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Premature Cancellation feature for blue/green #535

Open
juliev0 opened this issue Jan 30, 2025 · 0 comments
Open

Enable Premature Cancellation feature for blue/green #535

juliev0 opened this issue Jan 30, 2025 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@juliev0
Copy link
Collaborator

juliev0 commented Jan 30, 2025

Summary

If user rolls back to the prior version of their Rollout (especially PipelineRollout and MonoVertexRollout), it would be best if they don't have to wait for 5 minutes to start updating back to that version. (This is an ask from the Multiworkload team who will be doing multi-workload automatic rollback.)

Take the scenario of PipelineRollout in a blue/green state:

  • pipeline-0: "promoted" and pipeline-1: "upgrading"
  • PipelineRollout gets put back to the spec identical to "pipeline-0" before assessment is complete
  • We compare the PipelineRollout spec to the "pipeline-0" spec and determine that they are identical. If there is any new update, we can discontinue the in-progress update and start a new one. We perform the same logic we currently do when there is a new PipelineRollout spec after the assessment has been deemed "Failed".

Note: we cannot simply delete the "upgrading" one as one might think. This is because the existing "promoted" one could be on an older version of the isbsvc, and we don't want that. Therefore, we create a new "upgrading" one.


Message from the maintainers:

If you wish to see this enhancement implemented please add a 👍 reaction to this issue! We often sort issues this way to know what to prioritize.

@juliev0 juliev0 added the enhancement New feature or request label Jan 30, 2025
@juliev0 juliev0 self-assigned this Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant