We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
getVideoMetaData
On Android, getVideoMetaData does not take into account video orientation. A portrait video has the same width and height as a landscape one.
Width and height should be reversed for portrait images vs landscape ones.
0.76.6
1.10.3
Looking at the code here
react-native-compressor/android/src/main/java/com/reactnativecompressor/Video/VideoMain.kt
Lines 59 to 86 in 0e316b3
It seems that use of METADATA_KEY_VIDEO_ROTATION in there somewhere is necessary, similar to
METADATA_KEY_VIDEO_ROTATION
react-native-compressor/android/src/main/java/com/reactnativecompressor/Video/VideoCompressor/compressor/Compressor.kt
Lines 107 to 117 in 0e316b3
The text was updated successfully, but these errors were encountered:
👋 @andrejpavlovic Thanks for opening your issue here! If you find this package useful hit the star🌟!
Sorry, something went wrong.
No branches or pull requests
Current behavior
On Android,
getVideoMetaData
does not take into account video orientation. A portrait video has the same width and height as a landscape one.Expected behavior
Width and height should be reversed for portrait images vs landscape ones.
Platform
React Native Version
0.76.6
React Native Compressor Version
1.10.3
Reproducible Steps And Demo
Looking at the code here
react-native-compressor/android/src/main/java/com/reactnativecompressor/Video/VideoMain.kt
Lines 59 to 86 in 0e316b3
It seems that use of
METADATA_KEY_VIDEO_ROTATION
in there somewhere is necessary, similar toreact-native-compressor/android/src/main/java/com/reactnativecompressor/Video/VideoCompressor/compressor/Compressor.kt
Lines 107 to 117 in 0e316b3
The text was updated successfully, but these errors were encountered: