Invert notifications_enabled bitfield logic to save a write on each C…

…Atom_new
nucleic · Feb 6, 2025 · 969291a · 969291a
1 parent 8196ead
commit 969291a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/atom/src/catom.cpp b/atom/src/catom.cpp
@@ -63,7 +63,6 @@ CAtom_new( PyTypeObject* type, PyObject* args, PyObject* kwargs )
         atom->slots = reinterpret_cast<PyObject**>( slots );
         atom->set_slot_count( count );
     }
-    atom->set_notifications_enabled( true );
     return selfptr.release();
 }
 

diff --git a/atom/src/catom.h b/atom/src/catom.h
@@ -21,7 +21,7 @@ namespace atom
 
 PACK(struct CAtomInfo {
     uint16_t slot_count;
-    bool notifications_enabled: 1;
+    bool notifications_disabled: 1;
     bool has_guards: 1;
     bool has_atomref: 1;
     bool is_frozen: 1;
@@ -66,12 +66,12 @@ struct CAtom
 
     bool get_notifications_enabled()
     {
-        return info.notifications_enabled;
+        return !info.notifications_disabled;
     }
 
     void set_notifications_enabled( bool enabled )
     {
-        info.notifications_enabled = enabled;
+        info.notifications_disabled = !enabled;
     }
 
     bool has_guards()