Invert notifications_enabled bitfield logic to save a write on each CAtom_new

frmdstryr · frmdstryr · commit 969291a492ec · 2025-02-06T08:42:01.000-05:00
diff --git a/atom/src/catom.cpp b/atom/src/catom.cpp
@@ -63,7 +63,6 @@ CAtom_new( PyTypeObject* type, PyObject* args, PyObject* kwargs )
         atom->slots = reinterpret_cast<PyObject**>( slots );
         atom->set_slot_count( count );
     }
-    atom->set_notifications_enabled( true );
     return selfptr.release();
 }
 
diff --git a/atom/src/catom.h b/atom/src/catom.h
@@ -21,7 +21,7 @@ namespace atom
 
 PACK(struct CAtomInfo {
     uint16_t slot_count;
-    bool notifications_enabled: 1;
+    bool notifications_disabled: 1;
     bool has_guards: 1;
     bool has_atomref: 1;
     bool is_frozen: 1;
@@ -66,12 +66,12 @@ struct CAtom
 
     bool get_notifications_enabled()
     {
-        return info.notifications_enabled;
+        return !info.notifications_disabled;
     }
 
     void set_notifications_enabled( bool enabled )
     {
-        info.notifications_enabled = enabled;
+        info.notifications_disabled = !enabled;
     }
 
     bool has_guards()

Original file line number	Diff line number	Diff line change
`@@ -63,7 +63,6 @@ CAtom_new( PyTypeObject* type, PyObject* args, PyObject* kwargs )`
`63`	`63`	`atom->slots = reinterpret_cast<PyObject**>( slots );`
`64`	`64`	`atom->set_slot_count( count );`
`65`	`65`	`}`
`66`		`- atom->set_notifications_enabled( true );`
`67`	`66`	`return selfptr.release();`
`68`	`67`	`}`
`69`	`68`
Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,7 @@ namespace atom`
`21`	`21`
`22`	`22`	`PACK(struct CAtomInfo {`
`23`	`23`	`uint16_t slot_count;`
`24`		`- bool notifications_enabled: 1;`
	`24`	`+ bool notifications_disabled: 1;`
`25`	`25`	`bool has_guards: 1;`
`26`	`26`	`bool has_atomref: 1;`
`27`	`27`	`bool is_frozen: 1;`
`@@ -66,12 +66,12 @@ struct CAtom`
`66`	`66`
`67`	`67`	`bool get_notifications_enabled()`
`68`	`68`	`{`
`69`		`- return info.notifications_enabled;`
	`69`	`+ return !info.notifications_disabled;`
`70`	`70`	`}`
`71`	`71`
`72`	`72`	`void set_notifications_enabled( bool enabled )`
`73`	`73`	`{`
`74`		`- info.notifications_enabled = enabled;`
	`74`	`+ info.notifications_disabled = !enabled;`
`75`	`75`	`}`
`76`	`76`
`77`	`77`	`bool has_guards()`