From 8723c0bafffbbdb0d19792122ab6f74c9931aa97 Mon Sep 17 00:00:00 2001 From: frmdstryr Date: Sat, 1 Feb 2025 15:21:20 -0500 Subject: [PATCH] Use emplace instead of insert/push in ObserverPool::add --- atom/src/observerpool.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/atom/src/observerpool.cpp b/atom/src/observerpool.cpp index f861b852..1e0516c9 100644 --- a/atom/src/observerpool.cpp +++ b/atom/src/observerpool.cpp @@ -129,7 +129,7 @@ ObserverPool::add( cppy::ptr& topic, cppy::ptr& observer, uint8_t change_types ) } if( obs_free == obs_end ) { - m_observers.insert( obs_end, Observer( observer, change_types ) ); + m_observers.emplace( obs_end, observer, change_types ); ++topic_it->m_count; } else @@ -138,8 +138,8 @@ ObserverPool::add( cppy::ptr& topic, cppy::ptr& observer, uint8_t change_types ) } obs_offset += topic_it->m_count; } - m_topics.push_back( Topic( topic, 1 ) ); - m_observers.push_back( Observer(observer, change_types) ); + m_topics.emplace_back( topic, 1 ); + m_observers.emplace_back( observer, change_types ); }