Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Oauth? #58

Open
Stunner opened this issue Sep 30, 2017 · 5 comments
Open

Support for Oauth? #58

Stunner opened this issue Sep 30, 2017 · 5 comments

Comments

@Stunner
Copy link
Contributor

Stunner commented Sep 30, 2017

Was wondering if there is any support for Oauth2 namely, Implicit Grant, or ideally, Authorization Code Grant?

If not:

  • Are there plans to support any of these?
  • Would you be open to me (eventually) adding in this support?
@nuclearace
Copy link
Owner

I think OAuth2 flow is generally outside the scope of a client lib. Once you have a JWT from an OAuth session you can use it in the client with the Bearer prefix though. And there are some enums for the different scopes.

I'm not too sure on this though, but generally OAuth stuff involves separate libraries.

@Stunner
Copy link
Contributor Author

Stunner commented Sep 30, 2017

I'll look into this further, but I was thinking some additions to this library to make the whole sign in process with Oauth nicer. In the case for iOS, possibly provide a webview that is set to load the url required to begin the oath process. And possibly some hackery to set the redirect uri so the client may be able to intercept it and go from there.

This might warrant creating a new library just focused on the iOS platform itself, however. But I thought it would be good to bring this topic up for discussion.

@nuclearace
Copy link
Owner

Yeah I don't really want to include iOS specific code in the lib... Mostly because iOS is kind of a pain to install atm, and there's a good chance it'll be break and stay that way for awhile before someone notices.

@nuclearace
Copy link
Owner

That being said, I would probably need to see an implementation in a PR before I know if it's too hacky or scary to try and include in the lib.

@Stunner
Copy link
Contributor Author

Stunner commented Sep 30, 2017

Fair enough, thanks for the quick reply.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants