You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
There are a few instances where NMMA makes use of the key distance rather than luminosity_distance, but the former seems to be deprecated in favour of the latter. Therefore, one should make sure to remove all references to the former. grepping in NMMA, it seems the deprecated key occurs in the following files:
nmma/em/injection_summary.py
nmma/eos/create_injection.py
nmma/pbilby/analysis/main.py
in the example file injections.dat on NMMA found here
This bug can cause unexpected behavior when running injections with nmma-create-injection.py: when giving luminosity distances under the column name distance, the values are ignored and instead, values are sampled from the provided prior.
To Reproduce
Steps to reproduce the behavior:
Download example injections file injections.dat from NMMA repository.
Describe the bug
There are a few instances where NMMA makes use of the key
distance
rather thanluminosity_distance
, but the former seems to be deprecated in favour of the latter. Therefore, one should make sure to remove all references to the former. grepping in NMMA, it seems the deprecated key occurs in the following files:nmma/em/injection_summary.py
nmma/eos/create_injection.py
nmma/pbilby/analysis/main.py
injections.dat
on NMMA found hereThis bug can cause unexpected behavior when running injections with
nmma-create-injection.py
: when giving luminosity distances under the column namedistance
, the values are ignored and instead, values are sampled from the provided prior.To Reproduce
Steps to reproduce the behavior:
where the EOS could be replaced by this EOS file and an example of a prior file is:
Expected behavior
The injected luminosity distances are the ones written down in the distance column of the
injections.dat
file.The text was updated successfully, but these errors were encountered: