Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poor tensorflow training results for new model grid #301

Open
bfhealy opened this issue Jan 4, 2024 · 2 comments
Open

Poor tensorflow training results for new model grid #301

bfhealy opened this issue Jan 4, 2024 · 2 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@bfhealy
Copy link
Collaborator

bfhealy commented Jan 4, 2024

Posting this issue to further document efforts by @shreyasahasram08, @tsunhopang, @ThibeauWouters, and myself to achieve better training results for a new Bu2023Ye grid (see #292). The main difference from Bu2022Ye is that the new grid allows Yewind to take values of 0.2, 0.3, and 0.4, while the Bu2022Ye fixed the parameter at 0.3.

We are performing the following tests:

  • Ensuring parameter parsing from grid filenames works as intended
  • Running training only for grid files with Yewind = 0.3, which should replicate Bu2022Ye results

We are also exploring multiple areas of potential improvement, including:

  • Whether values of Yewind parameter are too widely spaced compared to the finer spacing of other parameters
  • Whether there are enough SVD coefficients to accurately represent the lightcurves (especially since loss curves look good)
  • Whether the NN architecture can be changed to provide a better mapping between params and SVD coeffs
@bfhealy bfhealy added bug Something isn't working enhancement New feature or request labels Jan 4, 2024
@bfhealy bfhealy added this to the Models & Training milestone Jan 4, 2024
@ThibeauWouters
Copy link
Contributor

I was able to retrain the model and got good inference results, I believe we can now close the issue, but I leave the final decision to the others in this thread (@bfhealy , @shreyasahasram08 , @tsunhopang )

@bfhealy
Copy link
Collaborator Author

bfhealy commented Mar 22, 2024

I agree with Thibeau's suggestion. I also retrained the model and made the benchmark plot below, which suggests generally good performance with the high reduced chi2 values coming from a few outliers near the edge of the grid.
benchmark_percentiles_Bu2023Ye

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants