You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The homepage mentions that the default unit for angles is radians, however everywhere in the documentation and examples degrees are used. This is particularly confusing when looking at the documentation of the __init__ function for cstrafo, where the zenith and azimuth descriptions are in degrees. If this could be updated to use radians instead, it would help first time users like me tremendously 👍🏽
The text was updated successfully, but these errors were encountered:
On a related note (I don't think this really deserves a separate issue), the azimuth description in the __init__ function of cstrafo is bit weird: "azimuth angle of the incoming signal/air-shower direction (0 deg is North, 90 deg is South)". Shouldn't it be +90 deg (or preferably +pi/2) is North, -90 deg (-pi/2) is South?
Hi, sorry that flipped my intention. To the first comment: I partially disagree, I think it is still useful to write values in deg to describe the geometry conventions we are using. After all using radians in "spoken" language is weird. As a compromise, why not writing both: South is at pi / 2 (90 deg)?
However, It would be appreciated if you could do propose and implement changes and create Pull-Request.
To your second comment: This seems indeed wrong. If North is at 0 deg, West should be at 90 deg. However, I would argue that this is not strictly true. The magnetic field vector defined what is North. If you give pass a vector [0, 0.5, 0.5], North will be at 90 deg (in the y-z plane). However, I assume that the default magnetic field vectors which are defined with the side follow the convention that the vector is in the x-z plane. Can you comment on this @cg-laser
The homepage mentions that the default unit for angles is radians, however everywhere in the documentation and examples degrees are used. This is particularly confusing when looking at the documentation of the
__init__
function forcstrafo
, where the zenith and azimuth descriptions are in degrees. If this could be updated to use radians instead, it would help first time users like me tremendously 👍🏽The text was updated successfully, but these errors were encountered: