Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on tiny-emitter #170

Open
kikuomax opened this issue Jan 16, 2024 · 2 comments
Open

Remove dependency on tiny-emitter #170

kikuomax opened this issue Jan 16, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@kikuomax
Copy link
Collaborator

Description

mockTableColumn uses tiny-emitter to emulate now obsolete $on and $off APIs. See https://v3-migration.vuejs.org/breaking-changes/events-api.html#event-bus
How about to replace tiny-emitter with our own implementation.

Why Buefy need this feature

tiny-emitter looks abandoned and having issues with TypeScript and ESM. So we should migrate from it before it would become a debt.

@kikuomax kikuomax added the enhancement New feature or request label Jan 16, 2024
@wesdevpro wesdevpro added this to the v0.1.5 milestone Jul 23, 2024
@wesdevpro wesdevpro moved this to 🏗 In progress in Buefy Vue3 Project Board Aug 10, 2024
@wesdevpro
Copy link

wesdevpro commented Aug 10, 2024

https://v3-migration.vuejs.org/breaking-changes/events-api.html

3.x Update
We removed $on, $off and $once methods from the instance completely. $emit is still a part of the existing API as it's used to trigger event handlers declaratively attached by a parent component

@wesdevpro wesdevpro modified the milestones: v0.2.0, v0.2.1 Jan 17, 2025
@wesdevpro wesdevpro moved this from 🏗 In progress to 🔖 Ready in Buefy Vue3 Project Board Jan 17, 2025
@wesdevpro wesdevpro moved this from 🔖 Ready to 🏗 In progress in Buefy Vue3 Project Board Jan 19, 2025
@wesdevpro
Copy link

I claim this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: 🏗 In progress
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants