Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use getblocknotifications API for meta handling #3142

Closed
roman-khimov opened this issue Feb 16, 2025 · 0 comments · Fixed by #3164
Closed

Use getblocknotifications API for meta handling #3142

roman-khimov opened this issue Feb 16, 2025 · 0 comments · Fixed by #3164
Assignees
@carpawell
Labels
enhancement Improving existing functionality I4 No visible changes neofs-storage Storage node application issues S3 Minimally significant U2 Seriously planned

Comments

@roman-khimov
Copy link
Member

It's not very efficient to subscribe to every container and we need a perfect block granularity wrt actions performed. So use the new getblocknotifications API introduced in 0.108.0 for container contract events. Don't filter for contracts initially, grab all of them, filter for the source and type only.
@roman-khimov roman-khimov added enhancement Improving existing functionality I4 No visible changes neofs-storage Storage node application issues S3 Minimally significant U2 Seriously planned labels Feb 16, 2025
@roman-khimov roman-khimov mentioned this issue Feb 16, 2025
Open
carpawell added a commit that referenced this issue Feb 20, 2025
@carpawell
node/meta: Use neo-go's new notification API
6792706 
Receive object notifications by block and process them in sync, not
independently. This is important for a consistent MPT state. Strictly speaking,
it was a bug before but it was a bug that was impossible to fix without neo-go's
new `getblocknotifications` API available with 0.108.0 release. Closes #3142.

Signed-off-by: Pavel Karpy <[email protected]>
@carpawell carpawell mentioned this issue Feb 20, 2025
Merged
carpawell added a commit that referenced this issue Feb 20, 2025
@carpawell
node/meta: Use neo-go's new notification API
67929c2 
Receive object notifications by block and process them in sync, not
independently. This is important for a consistent MPT state. Strictly speaking,
it was a bug before but it was a bug that was impossible to fix without neo-go's
new `getblocknotifications` API available with 0.108.0 release. Closes #3142.

Signed-off-by: Pavel Karpy <[email protected]>
carpawell added a commit that referenced this issue Feb 21, 2025
@carpawell
node/meta: Use neo-go's new notification API
3a77d2c 
Receive object notifications by block and process them in sync, not
independently. This is important for a consistent MPT state. Strictly speaking,
it was a bug before but it was a bug that was impossible to fix without neo-go's
new `getblocknotifications` API available with 0.108.0 release. Closes #3142.

Signed-off-by: Pavel Karpy <[email protected]>
carpawell added a commit that referenced this issue Feb 21, 2025
@carpawell
node/meta: Use neo-go's new notification API
96ef86e 
Receive object notifications by block and process them in sync, not
independently. This is important for a consistent MPT state. Strictly speaking,
it was a bug before but it was a bug that was impossible to fix without neo-go's
new `getblocknotifications` API available with 0.108.0 release. Closes #3142.

Signed-off-by: Pavel Karpy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carpawell carpawell

Labels
enhancement Improving existing functionality I4 No visible changes neofs-storage Storage node application issues S3 Minimally significant U2 Seriously planned
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

node/meta: Use neo-go's new notification API nspcc-dev/neofs-node
2 participants
@roman-khimov @carpawell