Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix write cache flushing loop to drop objects #3077

Open
roman-khimov opened this issue Dec 28, 2024 · 0 comments · May be fixed by #3169
Open

Fix write cache flushing loop to drop objects #3077

roman-khimov opened this issue Dec 28, 2024 · 0 comments · May be fixed by #3169
Assignees
@End-rey
Labels
enhancement Improving existing functionality I3 Minimal impact neofs-storage Storage node application issues performance More of something per second S2 Regular significance U2 Seriously planned
Milestone
v0.45.0

Comments

@roman-khimov
Copy link
Member

Is your feature request related to a problem? Please describe.

I'm always frustrated when objects may be stored in writecache forever. That's not the way it's supposed to work.

Describe the solution you'd like

Drop files from write cache when they're moved to the lower layer storage.

Additional context

See #2337 (comment).
@roman-khimov roman-khimov added enhancement Improving existing functionality neofs-storage Storage node application issues performance More of something per second U2 Seriously planned S2 Regular significance I3 Minimal impact labels Dec 28, 2024
@roman-khimov roman-khimov added this to the v0.45.0 milestone Dec 28, 2024
@roman-khimov roman-khimov mentioned this issue Dec 28, 2024
Open
@End-rey End-rey self-assigned this Feb 17, 2025
End-rey added a commit that referenced this issue Feb 21, 2025
@End-rey
writecache: delete objects from wc after flushing
c443373 
Drop files from write cache when they're moved to the lower layer storage. Also
drop code about `LRUCache` because it is not needed now, since the objects
themselves are deleted after flushing.

Closes #3077.

Signed-off-by: Andrey Butusov <[email protected]>
@End-rey End-rey linked a pull request Feb 21, 2025 that will close this issue
Open
End-rey added a commit that referenced this issue Feb 21, 2025
@End-rey
writecache: delete objects from wc after flushing
631e099 
Drop files from write cache when they're moved to the lower layer storage. Also
drop code about `LRUCache` because it is not needed now, since the objects
themselves are deleted after flushing.

Closes #3077.

Signed-off-by: Andrey Butusov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@End-rey End-rey

Labels
enhancement Improving existing functionality I3 Minimal impact neofs-storage Storage node application issues performance More of something per second S2 Regular significance U2 Seriously planned
Projects
None yet
Milestone
v0.45.0
Development

Successfully merging a pull request may close this issue.

Delete objects from wc after flushing nspcc-dev/neofs-node
2 participants
@roman-khimov @End-rey