Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement headers fetching via NeoFS BlockFetcher service #3574

Closed
AnnaShaleva opened this issue Sep 6, 2024 · 2 comments · Fixed by #3789
Closed

Implement headers fetching via NeoFS BlockFetcher service #3574

AnnaShaleva opened this issue Sep 6, 2024 · 2 comments · Fixed by #3789
Labels
enhancement Improving existing functionality I3 Minimal impact S2 Regular significance U2 Seriously planned
Milestone

Comments

@AnnaShaleva
Copy link
Member

Is your feature request related to a problem? Please describe.

#3515 is missing the ability to fetch block headers from NeoFS.

Describe the solution you'd like

  1. Allow to fetch headers. Header size is known (depending on some protocol configuration settings, but in general the size is known at every height). We need to use Blocks objects and use GetRange over every Block object to retrieve header (or just read a fixed-sized slice from Block object stream).
  2. Properly add headers to the chain, consider using some buffered queue.
  3. Properly integrate headers fetcher with StateSync module.

Describe alternatives you've considered

No alternatives.

@AnnaShaleva AnnaShaleva added I3 Minimal impact enhancement Improving existing functionality U2 Seriously planned S2 Regular significance labels Sep 6, 2024
@AnnaShaleva AnnaShaleva added this to the v0.106.4 milestone Sep 6, 2024
@roman-khimov
Copy link
Member

Notice that we already have a notion of expectedHeaderSizeWithEmptyWitness, then witness size is just a function of known number of validators.

@AnnaShaleva
Copy link
Member Author

Ref. nspcc-dev/neofs-api#313.

AliceInHunterland added a commit that referenced this issue Jan 20, 2025
AliceInHunterland added a commit that referenced this issue Jan 20, 2025
AliceInHunterland added a commit that referenced this issue Jan 21, 2025
AliceInHunterland added a commit that referenced this issue Jan 21, 2025
AliceInHunterland added a commit that referenced this issue Jan 21, 2025
AliceInHunterland added a commit that referenced this issue Jan 21, 2025
AliceInHunterland added a commit that referenced this issue Jan 21, 2025
AliceInHunterland added a commit that referenced this issue Jan 21, 2025
AliceInHunterland added a commit that referenced this issue Jan 22, 2025
Close #3574

Signed-off-by: Ekaterina Pavlova <[email protected]>

fix

Signed-off-by: Ekaterina Pavlova <[email protected]>
AliceInHunterland added a commit that referenced this issue Jan 22, 2025
AliceInHunterland added a commit that referenced this issue Jan 27, 2025
AliceInHunterland added a commit that referenced this issue Jan 27, 2025
AliceInHunterland added a commit that referenced this issue Jan 28, 2025
AliceInHunterland added a commit that referenced this issue Jan 28, 2025
AliceInHunterland added a commit that referenced this issue Jan 29, 2025
AliceInHunterland added a commit that referenced this issue Jan 30, 2025
AliceInHunterland added a commit that referenced this issue Jan 30, 2025
AliceInHunterland added a commit that referenced this issue Feb 4, 2025
AliceInHunterland added a commit that referenced this issue Feb 4, 2025
AliceInHunterland added a commit that referenced this issue Feb 6, 2025
AliceInHunterland added a commit that referenced this issue Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improving existing functionality I3 Minimal impact S2 Regular significance U2 Seriously planned
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants