Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nil argument wrongly gets converted to empty string #52

Open
Habbie opened this issue Nov 11, 2016 · 0 comments
Open

nil argument wrongly gets converted to empty string #52

Habbie opened this issue Nov 11, 2016 · 0 comments

Comments

@Habbie
Copy link

Habbie commented Nov 11, 2016

From the protocol docs:

The client library API should not return an empty string, but a nil object, when the server replies with a Null Bulk String. For example a Ruby library should return 'nil' while a C library should return NULL (or set a special flag in the reply object), and so forth.

There is no language on nils in commands, and sending an actual nil makes Redis complain. This leads me to believe there is simply no valid situation in which you pass nil to a command. Because of that, I think the 'map to empty' fix for #29 is wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant