Test/refactor p2sram #2451
Draft
Test/refactor p2sram #2451
+67
−64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 27, 2025
What is the change? - Fixes #83660 allowing device to now enter suspend mode even if CONFIG_DEBUG_THREAD_INFO is enabled. Why is this needed? - z_sys_post_kernel was cleared as part of #d778d5c to "allow debuggers to display the correct thread state after the first 3 instructions have run". This is not required while resuming from suspend and it prevents the device from entering suspend so, move it out of resume path. Signed-off-by: Sudan Landge <[email protected]>
What is the change? - APIs `pm_s2ram_mark_set` and `pm_s2ram_mark_check_and_clear`, used to set/check pm_s2ram magic marker, no longer have Arm specific limitations. Why is this needed? - These APIs are generic and should not have arch specific dependency. Signed-off-by: Sudan Landge <[email protected]>
What is the change? - This reverts commit 474d4c3 Why do we need this change? - This commit was added because Cortex-M didn't have a valid stack to make required functionality work however, the previous commit fixes this and makes interrupt stack available for use. This removes Arm specific limitation from these generic APIs so revert the commit to reflect the same. Signed-off-by: Sudan Landge <[email protected]>
adamkondraciuk
force-pushed
the
test/refactor_p2sram
branch
from
a5a3670 to
18786e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.