-
Notifications
You must be signed in to change notification settings - Fork 645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[nrf fromlist] susbys/dfu/img_util: refined ERASE PROGRESSIVELY imple… #2073
[nrf fromlist] susbys/dfu/img_util: refined ERASE PROGRESSIVELY imple… #2073
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The high-level DFU test for our sample project works now. Thanks for the fix!
a34c93f
to
305fc23
Compare
1cc6b02
to
554cd97
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apply comments from upstream to upstream then reapply here
554cd97
to
4d75caf
Compare
@nordicjm Revisit. |
The changes need to be made to the upstream PR, then brought in with a cherry pick, fromlist/fromtree must be a 1:1 with the upstream commits |
9ce031f
to
a495ed0
Compare
@nordicjm Synchronized. |
@nvlsianpu, please rebase as there is new GH action now and the sdk-zephyr PRs need to be rebased for it to run properly |
a495ed0
to
a0a34c2
Compare
@kapi-no rebased |
@carlescufi, why is the "Commit tags" job failing? It seems that the script is not able to cherry-pick the https://github.com/zephyrproject-rtos/zephyr/pull/79152/commits |
@nvlsianpu @kapi-no this means that the commit does not apply cleanly, and thus @nvlsianpu modified it while cherry-picking. Is that the case @nvlsianpu ? |
@carlescufi Yes that the case. I did 1st approach to that fix and this is the second one. In the end the code is the same, but commit content differs. Is that mean that I should do the revert before cherry-picking the fromlist commit? |
f47b8ab
to
c1c8e9a
Compare
This is needed to fix the upmerge regression for the DFU operation in the Fast Pair Locator Tag sample. The DFU process currently fails. Please do not remove the NCS 2.8 milestone. |
Also needed for Mesh as DFU image upload on nRF54L15 fails due to the commit being reverted. |
…LY for non-flash mem" This reverts commit 30f066a. Signed-off-by: Andrzej Puzdrowski <[email protected]>
…mentation Moved MCUboot trailer's status erase ahead any write operation, which is step which helps with addition of support for devices don't require explicit pager erase. For these kind of devices flattening of mcuboot image status in the trailer was introduced. Signed-off-by: Andrzej Puzdrowski <[email protected]> (cherry picked from commit 17c15e3)
c1c8e9a
to
0a78dd8
Compare
…mentation
Moved MCUboot trailer's status erase ahead any write operation.
Upstream PR: zephyrproject-rtos/zephyr#79152