dts: bindings: misc: nrf: Support disabling lfosc #1987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NordicBuilder
requested review from
jaz1-nordic,
kl-cruz,
magp-nordic,
masz-nordic and
nika-nordic
karstenkoenig
force-pushed
the
bicr_bindings_lfosc_disabled
branch
from
abc74b6 to
994df73
Compare
karstenkoenig
changed the title
karstenkoenig
force-pushed
the
bicr_bindings_lfosc_disabled
branch
from
994df73 to
3be6443
Compare
masz-nordic
approved these changes
Sep 3, 2024
|
Please add: |
karstenkoenig
force-pushed
the
bicr_bindings_lfosc_disabled
branch
from
3be6443 to
9fc97e6
Compare
nrf-squash! [nrf noup] dts: nordic: Add support for BICR generation The BICR LFOSC.LFXOCONFIG.MODE field supports disabling the usage of an external crystal oscillator to disable LFXO as LF clock source. This adds the enum to the binding, the rest of the codebase already supports the feature. Signed-off-by: Karsten Koenig <[email protected]>
karstenkoenig
force-pushed
the
bicr_bindings_lfosc_disabled
branch
from
9fc97e6 to
88b7e77
Compare
|
@anangl fixed, could you please check again? Corresponding sdk-nrf build is also green nrfconnect/sdk-nrf#17098 |
anangl
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The BICR LFOSC.LFXOCONFIG.MODE field supports disabling the usage of an external crystal oscillator to disable LFXO as LF clock source. This adds the enum to the binding, the rest of the codebase already supports the feature.
This is already supported in nrf-regtool here https://github.com/nrfconnect/nrf-regtool/commit/b23cdefbd0166b064fa946102b61bc6e097fd749