[nrf fromtree] twister: scripts: Split lines before processing #1972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
original PR: zephyrproject-rtos/zephyr#77352 |
katgiadla
approved these changes
Aug 26, 2024
gchwier
force-pushed
the
grch-splitlines
branch
from
228a2bc to
0e4e504
Compare
katgiadla
approved these changes
Aug 26, 2024
PerMac
approved these changes
Aug 26, 2024
gchwier
force-pushed
the
grch-splitlines
branch
from
0e4e504 to
588a8d2
Compare
|
added also changes to fix CI on Python 3.12: |
gchwier
force-pushed
the
grch-splitlines
branch
from
588a8d2 to
a39756f
Compare
fundakol
approved these changes
Aug 27, 2024
gchwier
force-pushed
the
grch-splitlines
branch
3 times, most recently
from
254b3af to
d72b9fa
Compare
Readline method sometimes receives more lines in buffer. Split them to avoid misinterpreting data in harness module. Signed-off-by: Grzegorz Chwierut <[email protected]> (cherry picked from commit 79ef0b6)
This change is removing some deprecation warnings which for some reason causing failing tests with Python 3.12 on CI #76877. Also, it fixes warnings from pytest like: PytestCollectionWarning: cannot collect test class 'TestPlan' because it has a __init__ constructor (from: scripts/tests/twister/test_testplan.py) Signed-off-by: Lukasz Fundakowski <[email protected]> (cherry picked from commit 857adb2)
Fix confusing `TypeError: 'type' object is not subscriptable` at _get_installed_packages() if twister runs on python version < 3.9 Signed-off-by: Dmitrii Golovanov <[email protected]> (cherry picked from commit b8bed5b)
gchwier
force-pushed
the
grch-splitlines
branch
from
d72b9fa to
152db4a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Readline method sometimes receives more lines in buffer. Split them to avoid misinterpreting data in harness module.
(cherry picked from commit 79ef0b6)