[nrf fromlist] scripts: snippets: Fix path output on windows #1569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I verified it locally that this resolves some errors seen on Windows CI https://nordicsemi.atlassian.net/browse/NCSDK-26338 |
PerMac
approved these changes
Mar 8, 2024
thst-nordic
approved these changes
Mar 8, 2024
thst-nordic
approved these changes
Mar 8, 2024
nordicjm
requested review from
anangl,
gmarull,
jciupis,
rlubos,
jukkar,
de-nordic,
koffes,
alexsven,
erikrobstad,
rick1082,
gWacey,
lemrey and
a team
as code owners
Fixes an issue with paths being output in windows-style with back slashes, this causes issues for certain escape sequences when cmake interprets them. Replace these paths with posix paths so that they are not treated as possible escape sequences. Signed-off-by: Jamie McCrae <[email protected]> (cherry picked from commit b680a6e)
nordicjm
force-pushed
the
cherrypickwindowsthing
branch
from
9388d38 to
9f39ecf
Compare
de-nordic
approved these changes
Mar 11, 2024
SeppoTakalo
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue with paths being output in windows-style with back slashes, this causes issues for certain escape sequences when cmake interprets them. Replace these paths with posix paths so that they are not treated as possible escape sequences.
Upstream PR: zephyrproject-rtos/zephyr#69963