Skip to content

Commit

Permalink
[nrf fromlist] scripts: ci: test_plan: use find_modules only when com…
Browse files Browse the repository at this point in the history
…mits are provided

Current implementation will not work if comits were not provided.
ie. use case with list of changed files will fail as args.commits is None.

Upstream PR: zephyrproject-rtos/zephyr#75927

Signed-off-by: Piotr Kosycarz <[email protected]>
  • Loading branch information
nordic-piks authored and rlubos committed Jul 18, 2024
1 parent 2af3400 commit ba97e9d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion scripts/ci/test_plan.py
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ def get_plan(self, options, integration=False, use_testsuite_root=True):
os.remove(fname)

def find_modules(self):
if 'west.yml' in self.modified_files:
if 'west.yml' in self.modified_files and args.commits is not None:
print(f"Manifest file 'west.yml' changed")
print("=========")
old_manifest_content = repo_to_scan.git.show(f"{args.commits[:-2]}:west.yml")
Expand Down

0 comments on commit ba97e9d

Please sign in to comment.