Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GHA: Change PR template #678

Merged
merged 1 commit into from
Feb 19, 2025
Merged

GHA: Change PR template #678

merged 1 commit into from
Feb 19, 2025

Conversation

totyz
Copy link
Contributor

@totyz totyz commented Feb 12, 2025

Introduce new CI parameter - Filters

CI parameters

Github_actions:
  #(branch, hash, pull/XXX/head)
  NRF_revision: main

  # Do not change after creating PR
  Create_NRF_PR: false
Jenkins:
  test-sdk-sidewalk: master

Description

JIRA ticket:

Self review

  • There is no commented code.
  • There are no TODO/FIXME comments without associated issue ticket.
  • Commits are properly organized.
  • Change has been tested.
  • Tests were updated (if applicable).

@github-actions github-actions bot added the source PR changing src files label Feb 12, 2025
@totyz
Copy link
Contributor Author

totyz commented Feb 12, 2025

To test this feature, see #677

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 12, 2025 •
edited
Loading

Sample diff used total

Memory usage did not change for any of the samples.

RobertGalatNordic
RobertGalatNordic approved these changes Feb 13, 2025
View reviewed changes
Copy link
Collaborator

@RobertGalatNordic RobertGalatNordic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

totyz
totyz commented Feb 13, 2025
View reviewed changes
.github/pull_request_template.md Outdated
# To reconfigure functional tests:
# use GH labels func-* (default is func-commit)
# or
# Use YAML Filters. Helper side to set filters: https://tester-pc:8080/test_mgmt
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Use YAML Filters. Helper side to set filters: https://tester-pc:8080/test_mgmt
# Use YAML Filters. Helper side to set filters: https://tester-pc.nordicsemi.no:8080/test_mgmt

@totyz
GHA: Change PR template
ec5031c 
Introduce new CI parameter - Filters

Signed-off-by: Tomasz Tyzenhauz <[email protected]>
@totyz totyz merged commit 899d3aa into nrfconnect:main Feb 19, 2025
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobertGalatNordic RobertGalatNordic RobertGalatNordic approved these changes

@ktaborowski ktaborowski Awaiting requested review from ktaborowski

Assignees
No one assigned
Labels
func-integration source PR changing src files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@totyz @RobertGalatNordic