Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suit: Add support for Ed25519PH #20050

Merged
merged 2 commits into from
Feb 6, 2025
Merged

Conversation

ahasztag
Copy link
Contributor

Enabled building SUIT envelopes with Ed25519PH and their verification by the SUIT bootloader.

@ahasztag ahasztag requested review from a team as code owners January 23, 2025 10:53
@github-actions github-actions bot added manifest changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Jan 23, 2025
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Jan 23, 2025

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff
suit-generator nrfconnect/suit-generator@b37972c nrfconnect/suit-generator@2e22c17 (main) nrfconnect/[email protected]
suit-processor nrfconnect/suit-processor@a499bca nrfconnect/suit-processor@a3f2b6d (main) nrfconnect/[email protected]

All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@NordicBuilder
Copy link
Contributor

NordicBuilder commented Jan 23, 2025

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 11

Inputs:

Sources:

sdk-nrf: PR head: 70a6f4f15a29a94666a64c597ede45d7a649e5bd
suit-generator: PR head: 2e22c176ba50930604519c3f70ee8ae5ba2a09ac
suit-processor: PR head: a3f2b6de5f94d8547211b781bde231017caa9cdc

more details

sdk-nrf:

PR head: 70a6f4f15a29a94666a64c597ede45d7a649e5bd
merge base: 1758d0b850a68d342b6aecb7b518e3e4b91b0ac9
target head (main): 470ff085003af81802286858ee3b18bf1f62b17d
Diff

suit-generator:

PR head: 2e22c176ba50930604519c3f70ee8ae5ba2a09ac
merge base: b37972cd90c122bb8f384f2509b72fad62c3aa4b
Diff

suit-processor:

PR head: a3f2b6de5f94d8547211b781bde231017caa9cdc
merge base: a499bcadceff8877da63a0a140c6a91ff2f87b25
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (38)
modules
│  ├── lib
│  │  ├── suit-generator
│  │  │  ├── .github
│  │  │  │  ├── workflows
│  │  │  │  │  │ contribs.yml
│  │  │  ├── .gitignore
│  │  │  ├── ncs
│  │  │  │  ├── Kconfig
│  │  │  │  ├── basic_kms.py
│  │  │  │  │ sign_script.py
│  │  │  ├── suit_generator
│  │  │  │  ├── cmd_image.py
│  │  │  │  ├── cmd_mpi.py
│  │  │  │  ├── cmd_sign.py
│  │  │  │  ├── suit
│  │  │  │  │  ├── security.py
│  │  │  │  │  ├── types
│  │  │  │  │  │  │ keys.py
│  │  │  │  │ suit_sign_script_base.py
│  │  │  ├── tests
│  │  │  │  ├── test_cmd_image.py
│  │  │  │  │ test_ncs_sign_script.py
│  │  ├── suit-processor
│  │  │  ├── cddl
│  │  │  │  │ cose_sign.cddl
│  │  │  ├── include
│  │  │  │  │ suit_types.h
│  │  │  ├── tests
│  │  │  │  ├── unit
│  │  │  │  │  ├── bootstrap_envelope
│  │  │  │  │  │  │ testcase.yaml
│  │  │  │  │  ├── decoder
│  │  │  │  │  │  ├── src
│  │  │  │  │  │  │  │ test_authenticate_manifest.c
│  │  │  │  │  │  │ testcase.yaml
│  │  │  │  │  ├── fetch_integrated_manifests
│  │  │  │  │  │  │ testcase.yaml
│  │  │  │  │  ├── fetch_integrated_payload
│  │  │  │  │  │  │ testcase.yaml
│  │  │  │  │  ├── manifest
│  │  │  │  │  │  │ testcase.yaml
│  │  │  │  │  ├── manifest_metadata
│  │  │  │  │  │  │ testcase.yaml
│  │  │  │  │  ├── nested_seq
│  │  │  │  │  │  │ testcase.yaml
│  │  │  │  │  ├── seq_execution
│  │  │  │  │  │  │ testcase.yaml
│  │  │  │  │  ├── seq_validation
│  │  │  │  │  │  │ testcase.yaml
│  │  │  │  │  ├── try_each
│  │  │  │  │  │  │ testcase.yaml
subsys
│  ├── suit
│  │  ├── mci
│  │  │  ├── CMakeLists.txt
│  │  │  ├── include
│  │  │  │  │ suit_mci.h
│  │  │  ├── src
│  │  │  │  ├── suit_mci_nrf54h20.c
│  │  │  │  │ suit_mci_nrf9280.c
│  │  ├── platform
│  │  │  ├── sdfw
│  │  │  │  ├── src
│  │  │  │  │  │ suit_plat_authenticate.c
sysbuild
│  │ Kconfig.suit
tests
│  ├── subsys
│  │  ├── suit
│  │  │  ├── common
│  │  │  │  ├── mci_test
│  │  │  │  │  │ mci_test.c
│  │  │  ├── mci
│  │  │  │  ├── prj.conf
│  │  │  │  ├── src
│  │  │  │  │  ├── api_positive_scenarios.c
│  │  │  │  │  │ sanity.c
│  │  │  ├── unit
│  │  │  │  ├── mocks
│  │  │  │  │  ├── include
│  │  │  │  │  │  │ mock_suit_mci.h
west.yml

Outputs:

Toolchain

Version: 342151af73
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:342151af73_912848a074

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister - Skipped: Skipping Build & Test as it succeeded in a previous run: 9
  • ✅ Integration tests
    • ✅ test-sdk-audio - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ desktop52_verification - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-boot - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-apps - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test_ble_nrf_config - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-ble_mesh - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-ble_samples - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-chip - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-nfc - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-nrf-iot_serial_lte_modem - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-nrf-iot_zephyr_lwm2m - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-nrf-iot_samples - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-nrf-iot_lwm2m - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ doc-internal - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-nrf-iot_thingy91 - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-nrf_crypto
    • ✅ test-fw-nrfconnect-rpc - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-rs - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-fem - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-tfm - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-thread - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-zigbee - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-sdk-find-my - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-nrf-iot_mosh - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-nrf-iot_positioning - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-sdk-sidewalk - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-sdk-wifi - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-low-level - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-sdk-pmic-samples - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-sdk-mcuboot - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-sdk-dfu - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-ps - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-secdom-samples-public - Skipped: Job was skipped as it succeeded in a previous run
    • ⚠️ test-sdk-dfu

Note: This message is automatically posted and updated by the CI

@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link.

Note: This comment is automatically posted by the Documentation Publish GitHub Action.

@ahasztag ahasztag marked this pull request as draft January 23, 2025 13:41
@ahasztag
Copy link
Contributor Author

Converting to draft, as it turned out the MCI code needs to be extended

@ahasztag ahasztag marked this pull request as ready for review January 23, 2025 15:37
@ahasztag ahasztag force-pushed the NCSDK-31353_ed25519ph branch from ae4a67c to 31ce9af Compare January 23, 2025 15:54
@ahasztag ahasztag force-pushed the NCSDK-31353_ed25519ph branch 2 times, most recently from d08ae43 to 162e700 Compare February 4, 2025 10:35
@ahasztag ahasztag requested a review from a team as a code owner February 4, 2025 10:35
@ahasztag ahasztag force-pushed the NCSDK-31353_ed25519ph branch 2 times, most recently from 7cde426 to 373f1b0 Compare February 5, 2025 13:03
Enabled building SUIT envelopes with Ed25519PH and
their verification by the SUIT bootloader.

Signed-off-by: Artur Hadasz <[email protected]>
@ahasztag ahasztag force-pushed the NCSDK-31353_ed25519ph branch from 373f1b0 to e13f964 Compare February 5, 2025 13:16
@ahasztag ahasztag requested a review from parttimaa February 5, 2025 13:17
@NordicBuilder NordicBuilder removed the DNM label Feb 5, 2025
Nordic elements can only use EdDSA, not Hashed EdDSA

Signed-off-by: Artur Hadasz <[email protected]>
@ahasztag ahasztag force-pushed the NCSDK-31353_ed25519ph branch from e13f964 to 70a6f4f Compare February 5, 2025 14:51
@tomchy tomchy merged commit 0075971 into nrfconnect:main Feb 6, 2025
13 checks passed
@ahasztag ahasztag deleted the NCSDK-31353_ed25519ph branch February 21, 2025 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. manifest manifest-suit-generator manifest-suit-processor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants