Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

applications: sdp: fix surplus clock edge #20017

Merged
merged 2 commits into from
Feb 10, 2025
Merged

applications: sdp: fix surplus clock edge #20017

merged 2 commits into from
Feb 10, 2025

Conversation

mif1-nordic
Copy link
Contributor

depends on #19877

@mif1-nordic mif1-nordic requested review from a team as code owners January 21, 2025 11:10
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Jan 21, 2025
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Jan 21, 2025 •
edited
Loading

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 42

Inputs:

Sources:

sdk-nrf: PR head: 4dc1ada1702facbf7f8ed2bc564c617c535edb81

more details

sdk-nrf:

PR head: 4dc1ada1702facbf7f8ed2bc564c617c535edb81
merge base: a8a73b35ae3d415c1f025aa94787b463b4bb206f
target head (main): 33a1b3429cc60252efb4948b005ead5ac7b71845
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (4) 
applications
│  ├── sdp
│  │  ├── mspi
│  │  │  ├── src
│  │  │  │  ├── hrt
│  │  │  │  │  ├── hrt-nrf54l15.s
│  │  │  │  │  ├── hrt.c
│  │  │  │  │  │ hrt.h
│  │  │  │  │ main.c

Outputs:

Toolchain

Version: 342151af73
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:342151af73_bbe5b33786

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 26
  • ✅ Integration tests
    • ✅ test-low-level
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-proprietary_esb
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-fw-nrfconnect-zigbee
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-sidewalk
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link.

Note: This comment is automatically posted by the Documentation Publish GitHub Action.

@mif1-nordic mif1-nordic force-pushed the surplus_clock_edge branch 9 times, most recently from ce8178c to e986d4c Compare January 22, 2025 13:17
@masz-nordic masz-nordic added this to the 3.0.0 milestone Jan 23, 2025
@mif1-nordic mif1-nordic force-pushed the surplus_clock_edge branch 7 times, most recently from 10bd414 to b7bdaae Compare January 27, 2025 13:18
masz-nordic
masz-nordic reviewed Jan 27, 2025
View reviewed changes
@mif1-nordic mif1-nordic force-pushed the surplus_clock_edge branch 5 times, most recently from 51dd3b8 to 7337dbc Compare January 29, 2025 14:39
@mif1-nordic mif1-nordic mentioned this pull request Jan 29, 2025
Merged
@mif1-nordic mif1-nordic force-pushed the surplus_clock_edge branch 12 times, most recently from 10bc120 to 924b341 Compare February 4, 2025 08:54
@mif1-nordic mif1-nordic force-pushed the surplus_clock_edge branch 3 times, most recently from d12a874 to 8498463 Compare February 5, 2025 07:59
magp-nordic
magp-nordic reviewed Feb 6, 2025
View reviewed changes
@mif1-nordic mif1-nordic force-pushed the surplus_clock_edge branch 2 times, most recently from 28a4fbd to 21718da Compare February 7, 2025 11:04
@masz-nordic
Copy link
Contributor

@mif1-nordic please rebase

@mif1-nordic @masz-nordic
applications: sdp: mspi: Fixed bit blocking on bus width change
ef57a3f 
Fixed bug where after increasing bus width using buffered registers,
in first clock cycle the mask for previous bus width was still present.

Signed-off-by: Michal Frankiewicz <[email protected]>
masz-nordic
masz-nordic reviewed Feb 10, 2025
View reviewed changes
applications/sdp/mspi/src/main.c Outdated
Comment on lines 249 to 250
/* Hardware issue workaround for MSPI_CPP_MODE_2,
* additional clock edge when transmitting in modes other than MSPI_CPP_MODE_0.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it for modes other than 0 or only for 2?

Copy link
Contributor Author

@mif1-nordic mif1-nordic Feb 10, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is for mode 2, 2-nd line of the comment is description of hardwaare issue.
Additional clock edge for modes other than 0 includes also mode 2

@mif1-nordic mif1-nordic mentioned this pull request Feb 10, 2025
Merged
@mif1-nordic
applications: sdp: mspi: Fixed additional clock edge in modes 1-3
4dc1ada 
Added workarounds to hardware issue causing,
additional clock edge in spi modes 1-3.

Signed-off-by: Michal Frankiewicz <[email protected]>
@masz-nordic masz-nordic merged commit f923bda into nrfconnect:main Feb 10, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nordicjm nordicjm nordicjm approved these changes

@masz-nordic masz-nordic masz-nordic approved these changes

@magp-nordic magp-nordic magp-nordic approved these changes

Assignees
No one assigned
Labels
changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added.
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@mif1-nordic @NordicBuilder @masz-nordic @nordicjm @magp-nordic