manifest: sdk-nrfxlib: nrf_modem: update library #19998

NordicBuilder · 2025-01-20T15:17:10Z

Automatically created by action-manifest-pr GH action from PR: nrfconnect/sdk-nrfxlib#1637

NordicBuilder · 2025-01-20T15:18:19Z

The following west manifest projects have changed revision in this Pull Request:

Name	Old Revision	New Revision	Diff
nrfxlib	nrfconnect/sdk-nrfxlib@`b5c1a84`	nrfconnect/sdk-nrfxlib@`b764e95` (`main`)	nrfconnect/[email protected]

✅ All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

NordicBuilder · 2025-01-20T15:21:30Z

CI Information

^{To view the history of this post, clich the 'edited' button above}
Build number: 37

Inputs:

Sources:

sdk-nrf: PR head: 88f064554df585e3045737b758735b501ff266cf
nrfxlib: PR head: b764e95911280fc961a16b836dedb4eadf9acaa2

more details

sdk-nrf:

PR head: 88f064554df585e3045737b758735b501ff266cf
merge base: 8c3501f11bc76a4640d38eff327102816f9f504e
target head (main): 8c3501f11bc76a4640d38eff327102816f9f504e
Diff

nrfxlib:

PR head: b764e95911280fc961a16b836dedb4eadf9acaa2
merge base: b5c1a8486da16af75d36a6221d677768bc9556a6
Diff

Github labels

Enabled	Name	Description
	ci-disabled	Disable the ci execution
	ci-all-test	Run all of ci, no test spec filtering will be done
	ci-force-downstream	Force execution of downstream even if twister fails
	ci-run-twister	Force run twister
	ci-run-zephyr-twister	Force run zephyr twister

List of changed files detected by CI (51)

nrfxlib
│  ├── nrf_modem
│  │  ├── doc
│  │  │  ├── CHANGELOG.rst
│  │  │  │ dectphy.rst
│  │  ├── include
│  │  │  ├── nrf_modem_dect_phy.h
│  │  │  │ nrf_modem_softsim.h
│  │  ├── lib
│  │  │  ├── cellular
│  │  │  │  ├── nrf9120
│  │  │  │  │  ├── hard-float
│  │  │  │  │  │  ├── libmodem.a
│  │  │  │  │  │  │ libmodem_log.a
│  │  │  │  │  ├── soft-float
│  │  │  │  │  │  ├── libmodem.a
│  │  │  │  │  │  │ libmodem_log.a
│  │  │  │  ├── nrf9160
│  │  │  │  │  ├── hard-float
│  │  │  │  │  │  ├── libmodem.a
│  │  │  │  │  │  │ libmodem_log.a
│  │  │  │  │  ├── soft-float
│  │  │  │  │  │  ├── libmodem.a
│  │  │  │  │  │  │ libmodem_log.a
│  │  │  │  ├── nrf9230
│  │  │  │  │  ├── hard-float
│  │  │  │  │  │  ├── libmodem.a
│  │  │  │  │  │  │ libmodem_log.a
│  │  │  │  │  ├── soft-float
│  │  │  │  │  │  ├── libmodem.a
│  │  │  │  │  │  │ libmodem_log.a
│  │  │  ├── dect_phy
│  │  │  │  ├── nrf9120
│  │  │  │  │  ├── hard-float
│  │  │  │  │  │  ├── libmodem.a
│  │  │  │  │  │  │ libmodem_log.a
│  │  │  │  │  ├── soft-float
│  │  │  │  │  │  ├── libmodem.a
│  │  │  │  │  │  │ libmodem_log.a
samples
│  ├── dect
│  │  ├── dect_phy
│  │  │  ├── dect_shell
│  │  │  │  ├── README.rst
│  │  │  │  ├── src
│  │  │  │  │  ├── dect
│  │  │  │  │  │  ├── common
│  │  │  │  │  │  │  ├── dect_common.h
│  │  │  │  │  │  │  ├── dect_common_settings.c
│  │  │  │  │  │  │  ├── dect_common_settings.h
│  │  │  │  │  │  │  ├── dect_common_utils.c
│  │  │  │  │  │  │  ├── dect_common_utils.h
│  │  │  │  │  │  │  ├── dect_phy_api_scheduler.c
│  │  │  │  │  │  │  ├── dect_phy_api_scheduler.h
│  │  │  │  │  │  │  ├── dect_phy_common.h
│  │  │  │  │  │  │  ├── dect_phy_common_rx.c
│  │  │  │  │  │  │  │ dect_phy_common_rx.h
│  │  │  │  │  │  ├── dect_phy_ctrl.c
│  │  │  │  │  │  ├── dect_phy_ctrl.h
│  │  │  │  │  │  ├── dect_phy_scan.c
│  │  │  │  │  │  ├── dect_phy_scan.h
│  │  │  │  │  │  ├── dect_phy_shell.c
│  │  │  │  │  │  ├── dect_phy_shell.h
│  │  │  │  │  │  ├── mac
│  │  │  │  │  │  │  ├── dect_phy_mac.c
│  │  │  │  │  │  │  ├── dect_phy_mac_client.c
│  │  │  │  │  │  │  ├── dect_phy_mac_cluster_beacon.c
│  │  │  │  │  │  │  ├── dect_phy_mac_cluster_beacon.h
│  │  │  │  │  │  │  ├── dect_phy_mac_ctrl.c
│  │  │  │  │  │  │  │ dect_phy_mac_nbr.c
│  │  │  │  │  │  ├── perf
│  │  │  │  │  │  │  │ dect_phy_perf.c
│  │  │  │  │  │  ├── ping
│  │  │  │  │  │  │  │ dect_phy_ping.c
│  │  │  │  │  │  ├── rf_tool
│  │  │  │  │  │  │  │ dect_phy_rf_tool.c
│  │  │  │  │  ├── main.c
│  │  │  │  │  ├── utils
│  │  │  │  │  │  │ desh_print.c
│  │  │  ├── hello_dect
│  │  │  │  ├── Kconfig
│  │  │  │  ├── src
│  │  │  │  │  │ main.c
west.yml

Outputs:

Toolchain

Version: 342151af73
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:342151af73_912848a074

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

◻️ Toolchain - Skipped: existing toolchain is used
✅ Build twister
- sdk-nrf test count: 403
✅ Integration tests
- ✅ test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
- ✅ test-fw-nrfconnect-nrf-iot_samples
- ✅ test-fw-nrfconnect-nrf-iot_lwm2m
- ✅ test-fw-nrfconnect-nrf-iot_mosh
- ✅ test-fw-nrfconnect-nrf-iot_positioning
- ⚠️ test-fw-nrfconnect-nrf-iot_cloud
- ⚠️ test-fw-nrfconnect-nrf-iot_libmodem-nrf

Disabled integration tests

- desktop52_verification
- doc-internal
- test_ble_nrf_config
- test-fw-nrfconnect-apps
- test-fw-nrfconnect-ble_mesh
- test-fw-nrfconnect-ble_samples
- test-fw-nrfconnect-boot
- test-fw-nrfconnect-chip
- test-fw-nrfconnect-fem
- test-fw-nrfconnect-nfc
- test-fw-nrfconnect-nrf-iot_serial_lte_modem
- test-fw-nrfconnect-nrf-iot_thingy91
- test-fw-nrfconnect-nrf_crypto
- test-fw-nrfconnect-ps
- test-fw-nrfconnect-rpc
- test-fw-nrfconnect-rs
- test-fw-nrfconnect-tfm
- test-fw-nrfconnect-thread
- test-fw-nrfconnect-zigbee
- test-low-level
- test-sdk-audio
- test-sdk-dfu
- test-sdk-find-my
- test-sdk-mcuboot
- test-sdk-pmic-samples
- test-sdk-sidewalk
- test-sdk-wifi
- test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

NordicBuilder · 2025-01-21T16:11:38Z

You can find the documentation preview for this PR at this link.

Note: This comment is automatically posted by the Documentation Publish GitHub Action.

peknis

Just a minor nit.

samples/dect/dect_phy/dect_shell/src/dect/common/dect_phy_common_rx.h

eivindj-nordic

Looks good! A lot of changes to dect_shell. Left some nits
Will do some more testing once final binaries are ready in sdk-nrfxlib PR.

samples/dect/dect_phy/dect_shell/src/dect/dect_phy_scan.c

samples/dect/dect_phy/dect_shell/src/dect/dect_phy_shell.c

samples/dect/dect_phy/dect_shell/src/dect/mac/dect_phy_mac_ctrl.c

samples/dect/dect_phy/dect_shell/src/dect/perf/dect_phy_perf.c

samples/dect/dect_phy/dect_shell/src/dect/ping/dect_phy_ping.c

samples/dect/dect_phy/hello_dect/Kconfig

samples/dect/dect_phy/hello_dect/README.rst

divipillai · 2025-01-27T07:46:58Z

samples/dect/dect_phy/hello_dect/README.rst

+   All nRF91 series devices with DECT NR+ PHY support has support for band index 0.
+   DECT NR+ band 4 (band index 1) is supported by the nRF9151 LACA A0 SiP for R&D evaluation purposes.
+   The nRF9151 LACA A0AB SiP will be qualified for DECT NR+ band 4 support.
+   The band group index 0 and 1 can be selected by enabling the :ref:`CONFIG_BAND_GROUP_INDEX_0 <CONFIG_BAND_GROUP_INDEX_0>` and :ref:`CONFIG_BAND_GROUP_INDEX_1 <CONFIG_BAND_GROUP_INDEX_1>` Kconfig options, respectively.


Suggested change

The band group index 0 and 1 can be selected by enabling the :ref:`CONFIG_BAND_GROUP_INDEX_0 <CONFIG_BAND_GROUP_INDEX_0>` and :ref:`CONFIG_BAND_GROUP_INDEX_1 <CONFIG_BAND_GROUP_INDEX_1>` Kconfig options, respectively.

To select the band group index 0 and 1, enable the :ref:`CONFIG_BAND_GROUP_INDEX_0 <CONFIG_BAND_GROUP_INDEX_0>` and :ref:`CONFIG_BAND_GROUP_INDEX_1 <CONFIG_BAND_GROUP_INDEX_1>` Kconfig options, respectively.

We would also need to define CONFIG_BAND_GROUP_INDEX_1 and CONFIG_BAND_GROUP_INDEX_0 in the docs to be linkable like CONFIG_BAND_GROUP_INDEX.

will fix the doc error as well.

Updated, used :kconfig:option: for the band group index 0 and 1, as we don't need to link them.

The :kconfig:option: syntax is not the correct one for these Kconfigs as these are not defined in the Kconfig reference. These are sample-specific Kconfigs.
Hence, these needs to be defined like we define CONFIG_BAND_GROUP_INDEX, CONFIG_MCS, CONFIG_TX_POWER etc.. in the sample doc - https://docs.nordicsemi.com/bundle/ncs-latest/page/nrf/samples/dect/dect_phy/hello_dect/README.html#configuration_options.

I see, thank you for clarifying. Updated now.

nordicjm

Some comments are questions/for your info, others need fixing. The output is a bit infuriating to see, there is printk, logging, and something else with 128 byte buffers all over the place... it's a bit of a mess

samples/dect/dect_phy/dect_shell/src/dect/common/dect_phy_api_scheduler.c

samples/dect/dect_phy/dect_shell/src/dect/common/dect_common_utils.c

samples/dect/dect_phy/dect_shell/src/dect/common/dect_phy_common_rx.c

samples/dect/dect_phy/dect_shell/src/dect/dect_phy_ctrl.c

samples/dect/dect_phy/dect_shell/src/dect/dect_phy_scan.c

nordicjm · 2025-01-27T08:59:54Z

samples/dect/dect_phy/hello_dect/Kconfig

@@ -7,9 +7,36 @@
 config CARRIER
 	int "Carrier to use"
 	default 0
+	range 525 551 if BAND_GROUP_INDEX_1


this should have a default when BAND_GROUP_INDEX_1 is enabled so it isn't set to a completely invalid value

This is set to fail by design, as the user must choose the carrier themselves for the area they are in.

so we should have a sample that fails to even configure when a user tries to build it and can't be changed?

warning: default value 0 on CARRIER (defined at /tmp/bb/nrf/samples/dect/dect_phy/hello_dect/Kconfig:7) clamped to 525 due to being outside the active range ([525, 551]) Parsing /tmp/bb/nrf/samples/dect/dect_phy/hello_dect/Kconfig Loaded configuration '/tmp/bb/zephyr/boards/nordic/nrf9151dk/nrf9151dk_nrf9151_ns_defconfig' Merged configuration '/tmp/bb/nrf/samples/dect/dect_phy/hello_dect/prj.conf' Merged configuration '/tmp/bb/nrf/samples/dect/dect_phy/hello_dect/_AA/hello_dect/zephyr/misc/generated/extra_kconfig_options.conf' Merged configuration '/tmp/bb/nrf/samples/dect/dect_phy/hello_dect/_AA/hello_dect/zephyr/.config.sysbuild' error: Aborting due to Kconfig warnings CMake Error at /tmp/bb/zephyr/cmake/modules/kconfig.cmake:395 (message): command failed with return code: 1 Call Stack (most recent call first): /tmp/bb/nrf/cmake/modules/kconfig.cmake:29 (include) /tmp/bb/zephyr/cmake/modules/zephyr_default.cmake:133 (include) /tmp/bb/zephyr/share/zephyr-package/cmake/ZephyrConfig.cmake:66 (include) /tmp/bb/zephyr/share/zephyr-package/cmake/ZephyrConfig.cmake:125 (include_boilerplate) /home/jamie/sysbuild/zephyr/share/zephyr-package/cmake/zephyr_package_search.cmake:117 (include) /home/jamie/sysbuild/zephyr/share/zephyr-package/cmake/ZephyrConfig.cmake:152 (check_zephyr_package) CMakeLists.txt:9 (find_package) -- Configuring incomplete, errors occurred! CMake Error at cmake/modules/sysbuild_extensions.cmake:514 (message): CMake configure failed for Zephyr project: hello_dect Location: /tmp/bb/nrf/samples/dect/dect_phy/hello_dect Call Stack (most recent call first): cmake/modules/sysbuild_images.cmake:20 (ExternalZephyrProject_Cmake) cmake/modules/sysbuild_default.cmake:20 (include) /tmp/bb/zephyr/share/zephyr-package/cmake/ZephyrConfig.cmake:75 (include) /tmp/bb/zephyr/share/zephyr-package/cmake/ZephyrConfig.cmake:117 (include_boilerplate) /tmp/bb/zephyr/share/sysbuild-package/cmake/SysbuildConfig.cmake:8 (include) template/CMakeLists.txt:10 (find_package)

I agree that this is not a good solution. Based on @jhirsi comment I've updated the sample to set band group index based on the carrier instead of having a separate Kconfig. User would still have to set CONFIG_CARRIER, though that should be clear from the BUILD_ASSERT.

samples/dect/dect_phy/hello_dect/Kconfig

eivindj-nordic · 2025-01-29T12:52:47Z

@nordicjm Any additional comments after latest changes?

Automatically created by Github Action samples: dect_phy: dect_shell: modem 1.1 support * Major modem/libmodem api update. Also did related changes: - new commands: activate/deactivate, radio_mode - new setting: startup radio mode for activation - pcc/pdc rx includes handle but not carrier/channel, thus keeping up to date information for that. - ping/perf/rf_tool: still own callbacks but no reinit of phy api, doing cancel(all) instead. - rf_tool: decreased --frame_repeat_count default to 15. - rf_tool: "rf_tool command done" print at the end. - radio mode query is used. - latency info usage is added. Jira: MOSH-621 samples: dect_phy: hello_dect: modem 1.1 support * Updates for libmodem 3.0.0 API changes. Adds support for configuring the band group index for using band 4 with the sample. Signed-off-by: Nordic Builder <[email protected]> Signed-off-by: Jani Hirsimäki <[email protected]> Signed-off-by: Eivind Jølsgard <[email protected]>

eivindj-nordic · 2025-01-29T13:42:05Z

Squashed release commits.

NordicBuilder requested a review from a team as a code owner January 20, 2025 15:17

github-actions bot added manifest changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Jan 20, 2025

NordicBuilder added manifest-nrfxlib DNM labels Jan 20, 2025

lemrey requested review from jhirsi and eivindj-nordic January 20, 2025 16:53

NordicBuilder force-pushed the auto-manifest-sdk-nrfxlib-1637 branch 2 times, most recently from 9bef07d to f5556be Compare January 21, 2025 15:53

NordicBuilder force-pushed the auto-manifest-sdk-nrfxlib-1637 branch 2 times, most recently from 8222e8c to 1107269 Compare January 21, 2025 16:43

jhirsi requested a review from a team as a code owner January 22, 2025 07:28

github-actions bot added the doc-required PR must not be merged without tech writer approval. label Jan 22, 2025

jhirsi force-pushed the auto-manifest-sdk-nrfxlib-1637 branch from 1af4135 to d1fc3eb Compare January 22, 2025 07:33

eivindj-nordic requested review from a team as code owners January 22, 2025 07:54

peknis approved these changes Jan 22, 2025

View reviewed changes

samples/dect/dect_phy/dect_shell/src/dect/common/dect_phy_common_rx.h Outdated Show resolved Hide resolved

eivindj-nordic force-pushed the auto-manifest-sdk-nrfxlib-1637 branch from 4c9146c to cb67b26 Compare January 22, 2025 08:30

jhirsi force-pushed the auto-manifest-sdk-nrfxlib-1637 branch from cb67b26 to a7fefc9 Compare January 22, 2025 09:31

NordicBuilder force-pushed the auto-manifest-sdk-nrfxlib-1637 branch 7 times, most recently from 5248854 to 520ee69 Compare January 24, 2025 05:30

eivindj-nordic force-pushed the auto-manifest-sdk-nrfxlib-1637 branch from 520ee69 to 6b2e197 Compare January 24, 2025 08:19

NordicBuilder force-pushed the auto-manifest-sdk-nrfxlib-1637 branch 2 times, most recently from c85e133 to a9e74cb Compare January 24, 2025 09:20

eivindj-nordic reviewed Jan 24, 2025

View reviewed changes

jhirsi force-pushed the auto-manifest-sdk-nrfxlib-1637 branch 2 times, most recently from a872f3e to 1b0d5d5 Compare January 24, 2025 12:37

NordicBuilder force-pushed the auto-manifest-sdk-nrfxlib-1637 branch 2 times, most recently from b60d2fe to ea44bac Compare January 24, 2025 14:10

lemrey approved these changes Jan 24, 2025

View reviewed changes

eivindj-nordic approved these changes Jan 26, 2025

View reviewed changes

jhirsi reviewed Jan 27, 2025

View reviewed changes

samples/dect/dect_phy/hello_dect/Kconfig Outdated Show resolved Hide resolved

eivindj-nordic force-pushed the auto-manifest-sdk-nrfxlib-1637 branch from ea44bac to 5485448 Compare January 27, 2025 07:28

jhirsi approved these changes Jan 27, 2025

View reviewed changes

eivindj-nordic force-pushed the auto-manifest-sdk-nrfxlib-1637 branch from 5485448 to d6d700e Compare January 27, 2025 07:34

eivindj-nordic requested a review from a team as a code owner January 27, 2025 07:34

divipillai reviewed Jan 27, 2025

View reviewed changes

eivindj-nordic force-pushed the auto-manifest-sdk-nrfxlib-1637 branch from d6d700e to a484b84 Compare January 27, 2025 08:54

nordicjm reviewed Jan 27, 2025

View reviewed changes

eivindj-nordic force-pushed the auto-manifest-sdk-nrfxlib-1637 branch 2 times, most recently from 1154e27 to b12ec79 Compare January 27, 2025 11:59

divipillai approved these changes Jan 27, 2025

View reviewed changes

jhirsi force-pushed the auto-manifest-sdk-nrfxlib-1637 branch from b12ec79 to 410f1f9 Compare January 27, 2025 14:02

eivindj-nordic requested a review from nordicjm January 28, 2025 07:53

nordicjm approved these changes Jan 29, 2025

View reviewed changes

NordicBuilder force-pushed the auto-manifest-sdk-nrfxlib-1637 branch from 410f1f9 to ea92579 Compare January 29, 2025 13:38

NordicBuilder removed the DNM label Jan 29, 2025

eivindj-nordic force-pushed the auto-manifest-sdk-nrfxlib-1637 branch from ea92579 to 88f0645 Compare January 29, 2025 13:41

rlubos merged commit 436fd2f into nrfconnect:main Jan 30, 2025
13 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

manifest: sdk-nrfxlib: nrf_modem: update library #19998

manifest: sdk-nrfxlib: nrf_modem: update library #19998

NordicBuilder commented Jan 20, 2025

NordicBuilder commented Jan 20, 2025 •

edited

Loading

NordicBuilder commented Jan 20, 2025 •

edited

Loading

NordicBuilder commented Jan 21, 2025

peknis left a comment

eivindj-nordic left a comment •

edited

Loading

divipillai Jan 27, 2025

divipillai Jan 27, 2025

divipillai Jan 27, 2025

eivindj-nordic Jan 27, 2025

divipillai Jan 27, 2025

eivindj-nordic Jan 27, 2025

nordicjm left a comment

nordicjm Jan 27, 2025

eivindj-nordic Jan 27, 2025

nordicjm Jan 27, 2025

eivindj-nordic Jan 27, 2025 •

edited

Loading

eivindj-nordic commented Jan 29, 2025

eivindj-nordic commented Jan 29, 2025

	The band group index 0 and 1 can be selected by enabling the :ref:`CONFIG_BAND_GROUP_INDEX_0 <CONFIG_BAND_GROUP_INDEX_0>` and :ref:`CONFIG_BAND_GROUP_INDEX_1 <CONFIG_BAND_GROUP_INDEX_1>` Kconfig options, respectively.
	To select the band group index 0 and 1, enable the :ref:`CONFIG_BAND_GROUP_INDEX_0 <CONFIG_BAND_GROUP_INDEX_0>` and :ref:`CONFIG_BAND_GROUP_INDEX_1 <CONFIG_BAND_GROUP_INDEX_1>` Kconfig options, respectively.

manifest: sdk-nrfxlib: nrf_modem: update library #19998

manifest: sdk-nrfxlib: nrf_modem: update library #19998

Conversation

NordicBuilder commented Jan 20, 2025

NordicBuilder commented Jan 20, 2025 • edited Loading

NordicBuilder commented Jan 20, 2025 • edited Loading

CI Information

Inputs:

Sources:

Github labels

Outputs:

Toolchain

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

NordicBuilder commented Jan 21, 2025

peknis left a comment

Choose a reason for hiding this comment

eivindj-nordic left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nordicjm left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

eivindj-nordic Jan 27, 2025 • edited Loading

Choose a reason for hiding this comment

eivindj-nordic commented Jan 29, 2025

eivindj-nordic commented Jan 29, 2025

NordicBuilder commented Jan 20, 2025 •

edited

Loading

NordicBuilder commented Jan 20, 2025 •

edited

Loading

eivindj-nordic left a comment •

edited

Loading

eivindj-nordic Jan 27, 2025 •

edited

Loading