applications: sdp: reduced IPC structures #19877

mif1-nordic · 2025-01-13T13:47:22Z

Depends on #19449

NordicBuilder · 2025-01-13T13:48:34Z

The following west manifest projects have changed revision in this Pull Request:

Name	Old Revision	New Revision	Diff

✅ All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

NordicBuilder · 2025-01-13T13:55:29Z

CI Information

^{To view the history of this post, clich the 'edited' button above}
Build number: 48

Inputs:

Sources:

sdk-nrf: PR head: d51395ecd1b883fe7747dee125b6b370576d48aa

more details

sdk-nrf:

PR head: d51395ecd1b883fe7747dee125b6b370576d48aa
merge base: 30bd02b2229f9836f5eca6dd02ea273f110f6514
target head (main): 30bd02b2229f9836f5eca6dd02ea273f110f6514
Diff

Github labels

Enabled	Name	Description
	ci-disabled	Disable the ci execution
	ci-all-test	Run all of ci, no test spec filtering will be done
	ci-force-downstream	Force execution of downstream even if twister fails
	ci-run-twister	Force run twister
	ci-run-zephyr-twister	Force run zephyr twister

List of changed files detected by CI (6)

applications
│  ├── sdp
│  │  ├── mspi
│  │  │  ├── src
│  │  │  │  ├── hrt
│  │  │  │  │  ├── hrt-nrf54l15.s
│  │  │  │  │  ├── hrt.c
│  │  │  │  │  │ hrt.h
│  │  │  │  │ main.c
drivers
│  ├── mspi
│  │  │ mspi_nrfe.c
include
│  ├── drivers
│  │  ├── mspi
│  │  │  │ nrfe_mspi.h

Outputs:

Toolchain

Version: 342151af73
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:342151af73_912848a074

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

◻️ Toolchain - Skipped: existing toolchain is used
✅ Build twister
- sdk-nrf test count: 26
✅ Integration tests
- ✅ test-low-level

Disabled integration tests

- desktop52_verification
- doc-internal
- test_ble_nrf_config
- test-fw-nrfconnect-apps
- test-fw-nrfconnect-ble_mesh
- test-fw-nrfconnect-ble_samples
- test-fw-nrfconnect-boot
- test-fw-nrfconnect-chip
- test-fw-nrfconnect-fem
- test-fw-nrfconnect-nfc
- test-fw-nrfconnect-nrf-iot_mosh
- test-fw-nrfconnect-nrf-iot_positioning
- test-fw-nrfconnect-nrf-iot_samples
- test-fw-nrfconnect-nrf-iot_serial_lte_modem
- test-fw-nrfconnect-nrf-iot_thingy91
- test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
- test-fw-nrfconnect-nrf_crypto
- test-fw-nrfconnect-ps
- test-fw-nrfconnect-rpc
- test-fw-nrfconnect-rs
- test-fw-nrfconnect-tfm
- test-fw-nrfconnect-thread
- test-fw-nrfconnect-zigbee
- test-sdk-audio
- test-sdk-dfu
- test-sdk-find-my
- test-sdk-mcuboot
- test-sdk-pmic-samples
- test-sdk-sidewalk
- test-sdk-wifi
- test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

drivers/mspi/mspi_nrfe.c

NordicBuilder · 2025-01-15T13:09:54Z

You can find the documentation preview for this PR at this link.

Note: This comment is automatically posted by the Documentation Publish GitHub Action.

applications/sdp/mspi/boards/nrf54l15dk_nrf54l15_cpuflpr.conf

magp-nordic

Revied only the new structures definitions.

include/drivers/mspi/nrfe_mspi.h

applications/sdp/mspi/src/hrt/hrt.c

magp-nordic

I am a little worried that you add support for more than one peripheral device along with modifying IPC structure. IIRC, previously we only stored information about more CE pins, but it was not possible to have more than one peripheral device, at least on the FLPR side. Those changes should be in a separate commit, or separate PR, if it is more convenient to you. Same goes to changing dummy cycles mechanics.

include/drivers/mspi/nrfe_mspi.h

drivers/mspi/mspi_nrfe.c

include/drivers/mspi/nrfe_mspi.h

applications/sdp/mspi/src/main.c

applications/sdp/mspi/src/hrt/hrt.h

drivers/mspi/mspi_nrfe.c

applications/sdp/mspi/src/main.c

mif1-nordic · 2025-02-04T08:56:25Z

I am a little worried that you add support for more than one peripheral device along with modifying IPC structure. IIRC, previously we only stored information about more CE pins, but it was not possible to have more than one peripheral device, at least on the FLPR side. Those changes should be in a separate commit, or separate PR, if it is more convenient to you. Same goes to changing dummy cycles mechanics.

@magp-nordic moved dummy cycles part to separate commit, as for multiple devices, added line do commit description

drivers/mspi/mspi_nrfe.c

include/drivers/mspi/nrfe_mspi.h

applications/sdp/mspi/src/main.c

magp-nordic · 2025-02-04T11:01:22Z

drivers/mspi/mspi_nrfe.c

-static void ep_recv(const void *data, size_t len, void *priv)
-{
-	(void)priv;
-
-	ipc_recv_clbk(data, len);
-}


Nit: It would be better to put the body of ipc_recv_clbk in ep_recv instead of removing ep_recv, but you can leave it as it is now.

bjarki-andreasen

Looks fine, just have a note about avoiding defining new types, especially if we intend to upstream some of this :)

include/drivers/mspi/nrfe_mspi.h

Implemented smaller structures and reduced ammount of opcodes in IPC. Added support for multiple target devices. Signed-off-by: Michal Frankiewicz <[email protected]>

Fixed dummy cycles implementation. Changed dummy cycles limit from 32 to UINT32_MAX. Signed-off-by: Michal Frankiewicz <[email protected]>

mif1-nordic requested review from a team as code owners January 13, 2025 13:47

github-actions bot added the manifest label Jan 13, 2025

NordicBuilder added manifest-zephyr DNM labels Jan 13, 2025

mif1-nordic force-pushed the Ipc_Reduced_Structures branch from 3f4fe33 to 860ba08 Compare January 13, 2025 13:57

jaz1-nordic reviewed Jan 13, 2025

View reviewed changes

drivers/mspi/mspi_nrfe.c Outdated Show resolved Hide resolved

drivers/mspi/mspi_nrfe.c Outdated Show resolved Hide resolved

drivers/mspi/mspi_nrfe.c Outdated Show resolved Hide resolved

mif1-nordic force-pushed the Ipc_Reduced_Structures branch from 860ba08 to 49791bb Compare January 14, 2025 16:11

masz-nordic added this to the 3.0.0 milestone Jan 14, 2025

mif1-nordic force-pushed the Ipc_Reduced_Structures branch 3 times, most recently from bcbe9c9 to 51738bc Compare January 15, 2025 12:51

github-actions bot added changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. and removed manifest labels Jan 15, 2025

NordicBuilder removed manifest-zephyr DNM labels Jan 15, 2025

mif1-nordic force-pushed the Ipc_Reduced_Structures branch 3 times, most recently from b2f47e9 to 461afba Compare January 15, 2025 15:29

tejlmand reviewed Jan 16, 2025

View reviewed changes

applications/sdp/mspi/boards/nrf54l15dk_nrf54l15_cpuflpr.conf Outdated Show resolved Hide resolved

tejlmand mentioned this pull request Jan 16, 2025

application: sdp: mspi: Ipc Hrt Connection #19449

Merged

mif1-nordic force-pushed the Ipc_Reduced_Structures branch from 461afba to 000dcf7 Compare January 16, 2025 11:06

magp-nordic reviewed Jan 16, 2025

View reviewed changes

mif1-nordic force-pushed the Ipc_Reduced_Structures branch from 000dcf7 to 61ce62d Compare January 16, 2025 12:19

masz-nordic requested review from tejlmand and nordic-krch January 30, 2025 12:08

masz-nordic reviewed Jan 30, 2025

View reviewed changes

applications/sdp/mspi/src/hrt/hrt.c Outdated Show resolved Hide resolved

mif1-nordic force-pushed the Ipc_Reduced_Structures branch from 9b273ce to 552cec2 Compare January 30, 2025 13:03

magp-nordic requested changes Jan 30, 2025

View reviewed changes

jaz1-nordic reviewed Jan 30, 2025

View reviewed changes

applications/sdp/mspi/src/hrt/hrt.h Show resolved Hide resolved

drivers/mspi/mspi_nrfe.c Show resolved Hide resolved

drivers/mspi/mspi_nrfe.c Outdated Show resolved Hide resolved

mif1-nordic force-pushed the Ipc_Reduced_Structures branch 3 times, most recently from 69951ce to e859fe9 Compare February 3, 2025 11:51

masz-nordic requested review from jaz1-nordic, magp-nordic and masz-nordic February 3, 2025 12:13

masz-nordic approved these changes Feb 3, 2025

View reviewed changes

applications/sdp/mspi/src/main.c Outdated Show resolved Hide resolved

applications/sdp/mspi/src/main.c Show resolved Hide resolved

mif1-nordic force-pushed the Ipc_Reduced_Structures branch 2 times, most recently from c06bd4f to 2259040 Compare February 3, 2025 14:38

mif1-nordic mentioned this pull request Feb 3, 2025

applications: sdp: mspi: RX #20092

Merged

mif1-nordic force-pushed the Ipc_Reduced_Structures branch from 2259040 to 554eab2 Compare February 4, 2025 08:53

nordicjm reviewed Feb 4, 2025

View reviewed changes

mif1-nordic force-pushed the Ipc_Reduced_Structures branch from 554eab2 to 64f8086 Compare February 4, 2025 09:40

jaz1-nordic approved these changes Feb 4, 2025

View reviewed changes

magp-nordic approved these changes Feb 4, 2025

View reviewed changes

bjarki-andreasen approved these changes Feb 4, 2025

View reviewed changes

include/drivers/mspi/nrfe_mspi.h Show resolved Hide resolved

masz-nordic force-pushed the Ipc_Reduced_Structures branch from 64f8086 to 35f41a5 Compare February 4, 2025 15:26

mif1-nordic force-pushed the Ipc_Reduced_Structures branch from 35f41a5 to 32a8555 Compare February 5, 2025 07:51

mif1-nordic added 3 commits February 5, 2025 08:59

drivers: mspi: Reduced IPC structures-drivers

e5b795d

Implemented smaller structures and reduced ammount of opcodes in IPC. Added support for multiple target devices. Signed-off-by: Michal Frankiewicz <[email protected]>

applications: sdp: mspi: Reduced IPC structures-applications

216f212

Implemented smaller structures and reduced ammount of opcodes in IPC. Added support for multiple target devices. Signed-off-by: Michal Frankiewicz <[email protected]>

applications: sdp: mspi: Dummy cycles fix

d51395e

Fixed dummy cycles implementation. Changed dummy cycles limit from 32 to UINT32_MAX. Signed-off-by: Michal Frankiewicz <[email protected]>

mif1-nordic force-pushed the Ipc_Reduced_Structures branch from 32a8555 to d51395e Compare February 5, 2025 07:59

masz-nordic merged commit c2042a1 into nrfconnect:main Feb 5, 2025
13 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

applications: sdp: reduced IPC structures #19877

applications: sdp: reduced IPC structures #19877

mif1-nordic commented Jan 13, 2025 •

edited

Loading

NordicBuilder commented Jan 13, 2025 •

edited

Loading

NordicBuilder commented Jan 13, 2025 •

edited

Loading

NordicBuilder commented Jan 15, 2025

magp-nordic left a comment

magp-nordic left a comment

mif1-nordic commented Feb 4, 2025

magp-nordic Feb 4, 2025

bjarki-andreasen left a comment

applications: sdp: reduced IPC structures #19877

applications: sdp: reduced IPC structures #19877

Conversation

mif1-nordic commented Jan 13, 2025 • edited Loading

NordicBuilder commented Jan 13, 2025 • edited Loading

NordicBuilder commented Jan 13, 2025 • edited Loading

CI Information

Inputs:

Sources:

Github labels

Outputs:

Toolchain

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

NordicBuilder commented Jan 15, 2025

magp-nordic left a comment

Choose a reason for hiding this comment

magp-nordic left a comment

Choose a reason for hiding this comment

mif1-nordic commented Feb 4, 2025

magp-nordic Feb 4, 2025

Choose a reason for hiding this comment

bjarki-andreasen left a comment

Choose a reason for hiding this comment

mif1-nordic commented Jan 13, 2025 •

edited

Loading

NordicBuilder commented Jan 13, 2025 •

edited

Loading

NordicBuilder commented Jan 13, 2025 •

edited

Loading