Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hids: Propagate errors in output and feature report handlers #19854

Closed
wants to merge 1 commit into from

Conversation

ndreys
Copy link

@ndreys ndreys commented Jan 12, 2025

Custom feature reports are often (ab)used in custom HID devices to implement arbitrary command/response handling and as such often require an ability to reject a given payload and signal an error condition. USB HID implementation in Zephyr allows that, so implement a similar capability in HIDS to match.

Custom feature reports are often (ab)used in custom HID devices to
implement arbitrary command/response handling and as such often
require an ability to reject a given payload and signal an error
condition. USB HID implementation in Zephyr allows that, so implement
a similar capability in HIDS to match.

Signed-off-by: Andrey Smirnov <[email protected]>
@ndreys ndreys requested a review from a team as a code owner January 12, 2025 18:31
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Jan 12, 2025
@NordicBuilder
Copy link
Contributor

Thank you for your contribution!
It seems you are not a member of the nrfconnect GitHub organization. External contributions are handled as follows:
Large contributions, affecting multiple subsystems for example, may be rejected if they are complex, may introduce regressions due to lack of test coverage, or if they are not consistent with the architecture of nRF Connect SDK.
PRs will be run in our continuous integration (CI) test system.
If CI passes, PRs will be tagged for review and merged on successful completion of review. You may be asked to make some modifications to your contribution during review.
If CI fails, PRs may be rejected or may be tagged for review and rework.
PRs that become outdated due to other changes in the repository may be rejected or rework requested.
External contributions will be prioritized for review based on the relevance to current development efforts in nRF Connect SDK. Bug fix PRs will be prioritized.
You may raise issues or ask for help from our Technical Support team by visiting https://devzone.nordicsemi.com/.

Note: This comment is automatically posted and updated by the Contribs GitHub Action.

@NordicBuilder NordicBuilder added the external External contribution label Jan 12, 2025
@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link.

Note: This comment is automatically posted by the Documentation Publish GitHub Action.

Copy link
Contributor

@pdunaj pdunaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is an api modification, the change requires changes in other places (wherever handlers are used).

I am doing a change in the area in other PRs. Let's see if we can do it so it won't force users to change the code.

Copy link

This pull request has been marked as stale because it has been open (more than) 30 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 7 days. Note, that you can always re-open a closed pull request at any time.

@github-actions github-actions bot added the Stale label Feb 13, 2025
@github-actions github-actions bot closed this Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. external External contribution Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants